* miscalculated vring size in virtio-0.9.5.pdf?
@ 2012-09-18 21:49 Laszlo Ersek
2012-09-19 5:42 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Laszlo Ersek @ 2012-09-18 21:49 UTC (permalink / raw)
To: virtualization
Hi,
the vring_size() formula in section 2.3 seems to miss
(a) "vring_avail.used_event" in the first ALIGN(), and
(b) "vring_used.flags", "vring_used.idx", "vring_used.avail_event" in
the second ALIGN().
vring_size() in Appendix A fixes (b) (no rounding up to page size
though), but (a) is wrong there too, I believe.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: miscalculated vring size in virtio-0.9.5.pdf?
2012-09-18 21:49 miscalculated vring size in virtio-0.9.5.pdf? Laszlo Ersek
@ 2012-09-19 5:42 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2012-09-19 5:42 UTC (permalink / raw)
To: Laszlo Ersek, virtualization
Laszlo Ersek <lersek@redhat.com> writes:
> Hi,
>
> the vring_size() formula in section 2.3 seems to miss
>
> (a) "vring_avail.used_event" in the first ALIGN(), and
>
> (b) "vring_used.flags", "vring_used.idx", "vring_used.avail_event" in
> the second ALIGN().
>
> vring_size() in Appendix A fixes (b) (no rounding up to page size
> though), but (a) is wrong there too, I believe.
Hi Laszlo,
The effect is the same, due to ALIGN(). However, the latest
copy of the spec on github should be consistent. Indeed, I cleaned up
the header in the Appendix so it actually compiles...
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-19 5:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-18 21:49 miscalculated vring size in virtio-0.9.5.pdf? Laszlo Ersek
2012-09-19 5:42 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).