virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Asias He <asias@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio-blk: Disable callback in virtblk_done()
Date: Fri, 28 Sep 2012 15:03:56 +0800	[thread overview]
Message-ID: <50654BDC.4060805@redhat.com> (raw)
In-Reply-To: <87fw623chz.fsf@rustcorp.com.au>

On 09/28/2012 02:08 PM, Rusty Russell wrote:
> Asias He <asias@redhat.com> writes:
>>> I forgot about the cool hack which MST put in to defer event updates
>>> using disable_cb/enable_cb.
>>
>> Hmm, are you talking about virtqueue_enable_cb_delayed()?
> 
> Just the fact that virtqueue_disable_cb() prevents updates of
> used_index, and then we do the update in virtqueue_enable_cb().

Okay.

-- 
Asias

  reply	other threads:[~2012-09-28  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25  2:36 [PATCH] virtio-blk: Disable callback in virtblk_done() Asias He
2012-09-25 14:08 ` Asias He
2012-09-27  0:10   ` Rusty Russell
2012-09-27  6:48     ` Asias He
2012-09-28  6:08       ` Rusty Russell
2012-09-28  7:03         ` Asias He [this message]
2012-09-27 10:01     ` Paolo Bonzini
2012-09-28  8:32     ` Michael S. Tsirkin
     [not found]     ` <50642400.5030906@redhat.com>
2012-10-02 14:42       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50654BDC.4060805@redhat.com \
    --to=asias@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).