From: Asias He <asias@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 4/6] tools/virtio: add vring_test.
Date: Wed, 23 Jan 2013 09:40:25 +0800 [thread overview]
Message-ID: <50FF3F89.50405@redhat.com> (raw)
In-Reply-To: <87k3r44y7j.fsf@rustcorp.com.au>
On 01/23/2013 07:03 AM, Rusty Russell wrote:
> Asias He <asias@redhat.com> writes:
>
>> On 01/17/2013 06:29 PM, Rusty Russell wrote:
>>> This is mainly to test the drivers/vhost/vringh.c code, but it also
>>> uses the drivers/virtio/virtio_ring.c code for the guest side.
>>
>> vringh_test.c does not compile here:
>> (This series on top of 9a9284153d965a57edc7162a8e57c14c97f3a935)
>>
>> $ cd tools/virtio
>> $ make
>> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
>> -fno-strict-overflow -MMD vringh_test.c -o vringh_test
>> In file included from ./linux/vringh.h:1:0,
>> from ./../../drivers/vhost/vringh.c:6,
>> from vringh_test.c:7:
>> ./linux/../../../include/linux/vringh.h:27:28: fatal error:
>> uapi/linux/uio.h: No such file or directory
>
> Oops, I forgot to add the file... it's a one-liner:
>
> tools/virtio/uapi/linux/uio.h:
> #include <sys/uio.h>
>
> I'll make a new branch for this, called vringh. It'll probably rebase
> as I neaten things up, but I'll try not to go crazy...
It compiles now.
FYI, I got some warnings:
../../drivers/virtio/virtio_ring.c: In function ‘virtqueue_kick_prepare’:
../../drivers/virtio/virtio_ring.c:309:3: warning: dereferencing
type-punned pointer will break strict-aliasing rules [-Wstrict-aliasin
g]
cc virtio_test.o virtio_ring.o -o virtio_test
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -MMD vringh_test.c -o vringh_test
In file included from vringh_test.c:7:0:
./../../drivers/vhost/vringh.c: In function ‘check_range’:
./../../drivers/vhost/vringh.c:119:2: warning: format ‘%llx’ expects
argument of type ‘long long unsigned int’, but argument 3 has type
‘u64’ [-Wformat]
./../../drivers/vhost/vringh.c: In function ‘__vringh_notify_enable’:
./../../drivers/vhost/vringh.c:402:3: warning: dereferencing type-punned
pointer will break strict-aliasing rules [-Wstrict-aliasing]
./../../drivers/vhost/vringh.c:405:8: warning: dereferencing type-punned
pointer will break strict-aliasing rules [-Wstrict-aliasing]
./../../drivers/vhost/vringh.c: In function ‘vringh_init_user’:
./../../drivers/vhost/vringh.c:499:3: warning: format ‘%zu’ expects
argument of type ‘size_t’, but argument 2 has type ‘unsigned int’ [
-Wformat]
./../../drivers/vhost/vringh.c: In function ‘vringh_init_kern’:
./../../drivers/vhost/vringh.c:707:3: warning: format ‘%zu’ expects
argument of type ‘size_t’, but argument 2 has type ‘unsigned int’ [
-Wformat]
In file included from vringh_test.c:8:0:
./../../drivers/virtio/virtio_ring.c: In function ‘virtqueue_kick_prepare’:
./../../drivers/virtio/virtio_ring.c:309:3: warning: dereferencing
type-punned pointer will break strict-aliasing rules [-Wstrict-alias
ing]
...
--
Asias
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2013-01-23 1:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:29 [PATCH 1/6] virtio_host: host-side implementation of virtio rings Rusty Russell
2013-01-17 10:29 ` [PATCH 2/6] tools/virtio: fix compile Rusty Russell
2013-01-17 10:29 ` [PATCH 3/6] tools/virtio: separate headers more Rusty Russell
2013-01-17 10:29 ` [PATCH 4/6] tools/virtio: add vring_test Rusty Russell
2013-01-22 8:25 ` Asias He
2013-01-22 23:03 ` Rusty Russell
2013-01-23 1:40 ` Asias He [this message]
2013-01-24 2:22 ` Rusty Russell
2013-01-17 10:29 ` [PATCH 5/6] vringh: separate callback for notification Rusty Russell
2013-01-17 10:29 ` [PATCH 6/6] tools/virtio: adapt for API changes Rusty Russell
2013-01-17 11:23 ` [PATCH 1/6] virtio_host: host-side implementation of virtio rings Michael S. Tsirkin
2013-01-17 11:49 ` Sjur Brændeland
2013-01-17 12:08 ` Michael S. Tsirkin
2013-01-21 2:36 ` Rusty Russell
2013-01-22 14:54 ` Sjur Brændeland
2013-01-21 2:34 ` Rusty Russell
2013-01-21 9:41 ` Michael S. Tsirkin
2013-01-21 11:52 ` Rusty Russell
2013-01-21 12:24 ` Michael S. Tsirkin
2013-01-21 12:40 ` Michael S. Tsirkin
2013-01-21 22:57 ` Rusty Russell
2013-01-22 6:57 ` Rusty Russell
2013-01-22 7:13 ` Rusty Russell
2013-01-22 8:12 ` Asias He
2013-01-23 1:56 ` Rusty Russell
2013-02-04 20:29 ` Sjur Brændeland
2013-02-04 21:44 ` Rusty Russell
2013-02-12 18:58 ` Sjur Brændeland
2013-02-13 10:25 ` Rusty Russell
2013-02-14 14:54 ` Sjur Brændeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FF3F89.50405@redhat.com \
--to=asias@redhat.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).