From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
Date: Mon, 28 Jan 2013 12:03:27 +0800 [thread overview]
Message-ID: <5105F88F.4030604@cn.fujitsu.com> (raw)
In-Reply-To: <1359190446-13677-1-git-send-email-ozaki.ryota@gmail.com>
On 01/26/2013 04:54 PM, Ryota Ozaki wrote:
> The register offset of InterruptACK is 0x064, not 0x060.
> Fix it.
>
> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
> CC: Pawel Moll <pawel.moll@arm.com>
> CC: Rusty Russell <rusty@rustcorp.com.au>
> CC: Jiri Kosina <trivial@kernel.org>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> drivers/virtio/virtio_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 31f966f..833e6db 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -75,7 +75,7 @@
> *
> * 0x050 W QueueNotify Queue notifier
> * 0x060 R InterruptStatus Interrupt status register
> - * 0x060 W InterruptACK Interrupt acknowledge register
> + * 0x064 W InterruptACK Interrupt acknowledge register
> * 0x070 RW Status Device status register
> *
> * 0x100+ RW Device-specific configuration space
>
next prev parent reply other threads:[~2013-01-28 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 8:54 [PATCH][trivial] virtio-mmio: fix wrong comment about register offset Ryota Ozaki
2013-01-28 4:03 ` Wanlong Gao [this message]
2013-01-28 10:05 ` Pawel Moll
2013-02-04 0:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5105F88F.4030604@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ozaki.ryota@gmail.com \
--cc=pawel.moll@arm.com \
--cc=trivial@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).