From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: linux-scsi@vger.kernel.org, kvm@vger.kernel.org, mst@redhat.com,
linux-kernel@vger.kernel.org, JBottomley@parallels.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data
Date: Mon, 11 Mar 2013 12:31:19 +0100 [thread overview]
Message-ID: <513DC087.6000508@redhat.com> (raw)
In-Reply-To: <1362969842-9145-2-git-send-email-gaowanlong@cn.fujitsu.com>
Il 11/03/2013 03:43, Wanlong Gao ha scritto:
> virtio_scsi_target_state is now empty, but we will find new uses
> for it in the next few patches. However, dropping the sglist lets
> us turn the array-of-pointers into a simple array, which simplifies
> the allocation.
>
> However, we do not leave the virtio_scsi_target_state structs in the
> flexible array member at the end of struct virtio_scsi, because
> we will place the virtqueues there in the next patches.
If you have to respin, consider improving the grammar:
virtio_scsi_target_state is now empty. We will find new uses for it in
the next few patches, so this patch does not drop it completely.
However, having dropped the sglist flexible array member, we can turn
the tgt array-of-pointers into a simple array. This simplifies the
allocation.
Even simpler would be to place the virtio_scsi_target_state structs in a
flexible array member at the end of struct virtio_scsi. But we do not
do that, because we will place the virtqueues there in the next patches.
Paolo
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
next prev parent reply other threads:[~2013-03-11 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 2:43 [PATCH V4 0/5] virtio-scsi multiqueue Wanlong Gao
2013-03-11 2:43 ` [PATCH V4 1/5] virtio-scsi: redo allocation of target data Wanlong Gao
2013-03-11 11:31 ` Paolo Bonzini [this message]
2013-03-19 6:57 ` Asias He
2013-03-11 2:43 ` [PATCH V4 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function Wanlong Gao
2013-03-11 2:44 ` [PATCH V4 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done Wanlong Gao
2013-03-11 2:44 ` [PATCH V4 4/5] virtio-scsi: introduce multiqueue support Wanlong Gao
2013-03-11 2:44 ` [PATCH V4 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug Wanlong Gao
2013-03-19 6:59 ` [PATCH V4 0/5] virtio-scsi multiqueue Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DC087.6000508@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@parallels.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).