From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix
Date: Wed, 13 Mar 2013 09:11:32 +0100 [thread overview]
Message-ID: <514034B4.5060100@redhat.com> (raw)
In-Reply-To: <20130312095514.GC22633@redhat.com>
Il 12/03/2013 10:55, Michael S. Tsirkin ha scritto:
> > Why? Why should qemu prevent from improving the driver and the benefit
> > to the other user of the driver? Kvm tool is already using it since last
> > Aug. This adds the missing disk hotplug support to kvm tool.
>
> Basically we shouldn't add stuff to kernel for a single user.
> Before we commit to support features forever, let's take the time
> to see that the interfaces satisfy the requirements of multiple users.
The userspace components of vhost-scsi do not need any new kernel API to
get this new feature. In fact, there is no new kernel API introduced by
the hotplug/hotunplug patches.
> > Plus, this is not a pure "feature", it is designed in virtio-scsi spec.
>
> The spec doesn't say it's a mandatory feature or did I miss something?
It's not mandatory to support hotplug. However, it is mandatory for the
device to provide an event virtqueue, even if it will never report an
event and it will do nothing with the virtqueue. For this reason, a
compliant userspace must already have all the support for this.
Paolo
prev parent reply other threads:[~2013-03-13 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 2:21 [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix Asias He
2013-03-08 2:21 ` [PATCH V2 1/6] tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint() Asias He
2013-03-08 2:21 ` [PATCH V2 2/6] tcm_vhost: Introduce tcm_vhost_check_feature() Asias He
2013-03-08 2:21 ` [PATCH V2 3/6] tcm_vhost: Introduce tcm_vhost_check_endpoint() Asias He
2013-03-08 2:21 ` [PATCH V2 4/6] tcm_vhost: Fix vs->vs_endpoint checking in vhost_scsi_handle_vq() Asias He
2013-03-08 2:21 ` [PATCH V2 5/6] tcm_vhost: Add hotplug/hotunplug support Asias He
2013-03-08 2:21 ` [PATCH V2 6/6] tcm_vhost: Flush vhost_work in vhost_scsi_flush() Asias He
2013-03-08 8:24 ` [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix Stefan Hajnoczi
2013-03-11 12:03 ` Michael S. Tsirkin
2013-03-12 2:31 ` Asias He
2013-03-12 9:55 ` Michael S. Tsirkin
2013-03-13 3:29 ` Asias He
2013-03-13 8:11 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514034B4.5060100@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).