From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm-devel <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
lf-virt <virtualization@lists.linux-foundation.org>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
target-devel <target-devel@vger.kernel.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon
Date: Tue, 09 Apr 2013 09:14:43 +0200 [thread overview]
Message-ID: <5163BFE3.3010507@redhat.com> (raw)
In-Reply-To: <87bo9oheex.fsf@codemonkey.ws>
Il 08/04/2013 23:59, Anthony Liguori ha scritto:
> > This patch refactors existing virtio-scsi code into VirtIOSCSICommon
> > in order to allow virtio_scsi_init_common() to be used by both internal
> > virtio_scsi_init() and external vhost-scsi-pci code.
> >
> > Changes in Patch-v2:
> > - Move ->get_features() assignment to virtio_scsi_init() instead of
> > virtio_scsi_init_common()
>
> Any reason we're not doing this as a QOM base class?
>
> Similiar to how the in-kernel PIT/PIC work using a common base class...
Because when the patch was written virtio-scsi was not a QOM class.
Paolo
next prev parent reply other threads:[~2013-04-09 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 1:08 [PATCH-v2 0/2] Add support for vhost-scsi-pci Nicholas A. Bellinger
2013-03-29 1:08 ` [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon Nicholas A. Bellinger
2013-04-08 21:59 ` Anthony Liguori
2013-04-09 4:08 ` Nicholas A. Bellinger
2013-04-09 7:14 ` Paolo Bonzini [this message]
2013-03-29 1:08 ` [PATCH-v2 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Nicholas A. Bellinger
2013-03-29 6:39 ` [PATCH-v2 0/2] Add support for vhost-scsi-pci Asias He
[not found] ` <20130329063903.GD32106@hj.localdomain>
2013-03-29 6:48 ` Nicholas A. Bellinger
[not found] ` <1364539739.10253.85.camel@haakon2.linux-iscsi.org>
2013-03-29 6:55 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163BFE3.3010507@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).