From: Wen Gu <guwen@linux.alibaba.com>
To: Thomas Gleixner <tglx@linutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Dust Li <dust.li@linux.alibaba.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David Woodhouse <dwmw2@infradead.org>,
virtualization@lists.linux.dev, Nick Shi <nick.shi@broadcom.com>,
Sven Schnelle <svens@linux.ibm.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-clk@vger.kernel.org
Subject: Re: [RFC] Defining a home/maintenance model for non-NIC PHC devices using the /dev/ptpX API
Date: Wed, 21 Jan 2026 22:29:41 +0800 [thread overview]
Message-ID: <51e8d8ce-f291-4e31-a938-2c1a0e8684c2@linux.alibaba.com> (raw)
In-Reply-To: <0afe19db-9c7f-4228-9fc2-f7b34c4bc227@linux.alibaba.com>
On 2026/1/9 10:56, Wen Gu wrote:
>
> #
> ## Proposal
> #
>
> 1. Reorganize drivers/ptp/ to make the interface/implementation split
> explicit,
>
> * drivers/ptp/core : PTP core infrastructure and API.
> (e.g. ptp_chardev.c, ptp_clock.c,
> ptp_sysfs.c, etc.)
>
> * drivers/ptp/pure : Non-network ("pure clock") implementation,
> they are typically platform/architecture/
> virtualization-provided time sources.
> (e.g. ptp_kvm, ptp_vmw, ptp_vmclock,
> ptp_s390, etc.)
>
> * drivers/ptp/* : Network timestamping oriented implementation,
> they primarily used together with IEEE1588
> over the network.
> (e.g. ptp_qoriq, ptp_pch, ptp_dp83640,
> ptp_idt82p33 etc.)
>
Thanks for the feedback so far. It seems we are close to consensus on
the directory split, as [1] summarized:
- drivers/ptp/core : PTP core infrastructure and API
- drivers/ptp/1588 : network/IEEE 1588 oriented PTP clocks
- drivers/ptp/emulating : platform/hardware/hypervisor-provided pure clocks
For how the existing drivers in `drivers/ptp` are categorized into the
directories above, please also refer to [1] and the follow-up replies.
> 2. Transition drivers/ptp/pure from netdev maintainership to
> clock/time maintainership (with an appropriate MAINTAINERS entry,
> e.g. PURE TIME PHC), since these PHC implementations are primarily
> clock devices and not network-oriented. New similar drivers can be
> added under drivers/ptp/pure as well.
Then the open item now is maintainership and the merge path.
Based on previous guidance[2] and the current MAINTAINERS structure,
it seems reasonable to have it maintained under the clock/timekeeping
domain (following the existing timekeeping pull chain), with a
dedicated MAINTAINERS entry.
Hi Thomas and clock/timekeeping maintainers,
Would you agree with this approach? If so, could you please advise on
the appropriate maintainer/reviewer for this MAINTAINERS entry?
Below is a strawman MAINTAINERS entry (happy to adjust):
EMULATING PTP CLOCK SUPPORT
L: linux-kernel@vger.kernel.org
S: Maintained
F: drivers/ptp/emulating/*
We (Alibaba) are also willing to be the maintainer for this entry as
a fallback.
[1] https://lore.kernel.org/netdev/b5a60753-85ed-4d61-a652-568393e0dff3@linux.alibaba.com/
[2] https://lore.kernel.org/netdev/20251216135848.174e010f@kernel.org/
Regards.
next prev parent reply other threads:[~2026-01-21 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 2:56 [RFC] Defining a home/maintenance model for non-NIC PHC devices using the /dev/ptpX API Wen Gu
2026-01-12 8:04 ` David Woodhouse
2026-01-14 9:06 ` Wen Gu
2026-01-12 11:00 ` Sven Schnelle
2026-01-12 12:15 ` Vadim Fedorenko
2026-01-12 13:24 ` Andrew Lunn
2026-01-12 14:52 ` Vadim Fedorenko
2026-01-14 9:13 ` Wen Gu
2026-01-14 10:50 ` Vadim Fedorenko
2026-01-14 12:45 ` Wen Gu
2026-01-13 4:21 ` Richard Cochran
2026-01-14 9:16 ` Wen Gu
2026-01-19 14:48 ` Manivannan Sadhasivam
2026-01-21 14:20 ` Wen Gu
2026-01-21 14:29 ` Wen Gu [this message]
2026-02-19 9:29 ` Imran Shaik
2026-02-25 1:45 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51e8d8ce-f291-4e31-a938-2c1a0e8684c2@linux.alibaba.com \
--to=guwen@linux.alibaba.com \
--cc=andrew+netdev@lunn.ch \
--cc=dust.li@linux.alibaba.com \
--cc=dwmw2@infradead.org \
--cc=kuba@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.shi@broadcom.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox