From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze Date: Tue, 17 Dec 2013 12:46:21 +0800 Message-ID: <52AFD71D.4000103@redhat.com> References: <1382947263-22145-1-git-send-email-asias@redhat.com> <52A95882.2020000@redhat.com> <87zjo0maw3.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87zjo0maw3.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: linux-scsi@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, pbonzini@redhat.com, Asias He List-Id: virtualization@lists.linuxfoundation.org On 12/17/2013 11:09 AM, Rusty Russell wrote: > Jason Wang writes: >> > On 10/28/2013 04:01 PM, Asias He wrote: >>> >> vqs are freed in virtscsi_freeze but the hotcpu_notifier is not >>> >> unregistered. We will have a use-after-free usage when the notifier >>> >> callback is called after virtscsi_freeze. >>> >> >>> >> Signed-off-by: Asias He > Please include a Fixes: line, especially if you want the CC: stable. > > Thanks, > Rusty. > > Ok, will post V2 soon.