From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] block: virtio_blk: don't hold spin lock during world switch
Date: Thu, 29 May 2014 21:19:14 -0600 [thread overview]
Message-ID: <5387F8B2.1070509@kernel.dk> (raw)
In-Reply-To: <1401418169-3361-1-git-send-email-ming.lei@canonical.com>
On 2014-05-29 20:49, Ming Lei wrote:
> Firstly, it isn't necessary to hold lock of vblk->vq_lock
> when notifying hypervisor about queued I/O.
>
> Secondly, virtqueue_notify() will cause world switch and
> it may take long time on some hypervisors(such as, qemu-arm),
> so it isn't good to hold the lock and block other vCPUs.
>
> On arm64 quad core VM(qemu-kvm), the patch can increase I/O
> performance a lot with VIRTIO_RING_F_EVENT_IDX enabled:
> - without the patch: 14K IOPS
> - with the patch: 34K IOPS
Patch looks good to me. I don't see a hit on my qemu-kvm testing, but it
definitely makes sense and I can see it hurting in other places.
--
Jens Axboe
next parent reply other threads:[~2014-05-30 3:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401418169-3361-1-git-send-email-ming.lei@canonical.com>
2014-05-30 3:19 ` Jens Axboe [this message]
2014-05-30 3:34 ` [PATCH] block: virtio_blk: don't hold spin lock during world switch Ming Lei
[not found] ` <CACVXFVPoG6_fL_MTRF+616W7UdHpSgjtMLBLeBn4OGR63haw3w@mail.gmail.com>
2014-05-30 3:35 ` Jens Axboe
2014-05-30 5:58 ` Ming Lei
2014-05-30 6:10 ` Rusty Russell
2014-05-30 13:52 ` Jens Axboe
2014-06-02 1:23 ` Rusty Russell
2014-06-02 13:06 ` Ming Lei
2014-06-11 14:44 ` Paolo Bonzini
2014-06-02 14:15 ` Jens Axboe
2014-05-30 6:05 ` Rusty Russell
2014-05-30 15:27 ` Michael S. Tsirkin
2014-05-30 2:49 Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5387F8B2.1070509@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).