From: Jens Axboe <axboe@kernel.dk>
To: Rusty Russell <rusty@rustcorp.com.au>, Ming Lei <ming.lei@canonical.com>
Cc: virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] block: virtio_blk: don't hold spin lock during world switch
Date: Fri, 30 May 2014 07:52:08 -0600 [thread overview]
Message-ID: <53888D08.1050602@kernel.dk> (raw)
In-Reply-To: <877g537q6d.fsf@rustcorp.com.au>
On 2014-05-30 00:10, Rusty Russell wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>> If Rusty agrees, I'd like to add it for 3.16 with a stable marker.
>
> Really stable? It improves performance, which is nice. But every patch
> which goes into the kernel fixes a bug, improves clarity, improves
> performance or adds a feature. I've now seen all four cases get CC'd
> into stable.
>
> Including some of mine explicitly not marked stable which get swept up
> by enthusiastic stable maintainers :(
>
> Is now there *any* patch short of a major rewrite which shouldn't get
> cc: stable?
I agree that there's sometimes an unfortunate trend there. I didn't
check, but my assumption was that this is a regression after the blk-mq
conversion, in which case I do think it belongs in stable.
But in any case, I think the patch is obviously correct and the wins are
sufficiently large to warrant a stable inclusion even if it isn't a
regression.
--
Jens Axboe
next prev parent reply other threads:[~2014-05-30 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401418169-3361-1-git-send-email-ming.lei@canonical.com>
2014-05-30 3:19 ` [PATCH] block: virtio_blk: don't hold spin lock during world switch Jens Axboe
2014-05-30 3:34 ` Ming Lei
[not found] ` <CACVXFVPoG6_fL_MTRF+616W7UdHpSgjtMLBLeBn4OGR63haw3w@mail.gmail.com>
2014-05-30 3:35 ` Jens Axboe
2014-05-30 5:58 ` Ming Lei
2014-05-30 6:10 ` Rusty Russell
2014-05-30 13:52 ` Jens Axboe [this message]
2014-06-02 1:23 ` Rusty Russell
2014-06-02 13:06 ` Ming Lei
2014-06-11 14:44 ` Paolo Bonzini
2014-06-02 14:15 ` Jens Axboe
2014-05-30 6:05 ` Rusty Russell
2014-05-30 15:27 ` Michael S. Tsirkin
2014-05-30 2:49 Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53888D08.1050602@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).