From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: Why is virtio_console not a tty? Date: Thu, 12 Jun 2014 18:26:53 -0700 Message-ID: <539A535D.6040000@zytor.com> References: <539A004F.20906@zytor.com> <877g4lpqil.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <877g4lpqil.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell , "virtualization@lists.linux-foundation.org" , Amit Shah List-Id: virtualization@lists.linuxfoundation.org On 06/12/2014 06:06 PM, Rusty Russell wrote: > "H. Peter Anvin" writes: >> I have gotten scattered reports of strange problems caused by the fact >> that virtio_console doesn't behave like a normal tty (support termios >> and so on.) This seems to be an odd restriction -- is there any >> fundamental reason for this design choice? > > Not that I know. I tacked it into hvc_console which provided the glue > to make it a console. Avoided me digging into console implementation, > which is pretty horrible. > > Given my ignorance, how much change do we need to make it behave like a > TTY? > hvc_console.c seems to set up a tty subsystem, so that is really confusing... -hpa