From: Paolo Bonzini <pbonzini@redhat.com>
To: David Marchand <david.marchand@6wind.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: Henning Schild <henning.schild@siemens.com>,
Olivier MATZ <olivier.matz@6wind.com>, kvm <kvm@vger.kernel.org>,
Claudio Fontana <claudio.fontana@huawei.com>,
qemu-devel <qemu-devel@nongnu.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
Vincent JARDIN <vincent.jardin@6wind.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [Qemu-devel] Why I advise against using ivshmem
Date: Wed, 18 Jun 2014 17:10:12 +0200 [thread overview]
Message-ID: <53A1ABD4.3000607@redhat.com> (raw)
In-Reply-To: <53A1A8BE.3000801@6wind.com>
Il 18/06/2014 16:57, David Marchand ha scritto:
> Hello Stefan,
>
> On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
>> One more thing to add to the list:
>>
>> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)
>>
>> The "flags" argument should be "size". Size should be checked before
>> accessing buf.
>
> You are welcome to send a fix and I will review it.
This is not what a maintainer should do. A maintainer should, if
possible, contribute fixes to improve the code.
I know this is very different from usual "company-style" development
(even open source software can be developed on with methods more typical
of proprietary software), but we're asking you to do it because you
evidently understand ivshmem better than us.
Claudio has more experience with free/open-source software. Since he's
interested in ivshmem, he can help you too. Perhaps you could try
sending out the patch, and Claudio can review it and send pull requests
at least in the beginning?
Paolo
next prev parent reply other threads:[~2014-06-18 15:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140610184818.2e490419@nbschild1>
2014-06-10 22:15 ` Using virtio for inter-VM communication Vincent JARDIN
2014-06-12 2:27 ` Rusty Russell
2014-06-12 5:32 ` Jan Kiszka
[not found] ` <53993B7B.7010404@siemens.com>
2014-06-13 0:47 ` Rusty Russell
2014-06-13 6:23 ` Jan Kiszka
2014-06-13 8:45 ` Paolo Bonzini
2014-06-15 6:20 ` Jan Kiszka
[not found] ` <539D3B35.2010706@web.de>
2014-06-17 5:24 ` Paolo Bonzini
[not found] ` <539FD124.6050007@redhat.com>
2014-06-17 5:57 ` Jan Kiszka
[not found] ` <53978375.6090707@6wind.com>
2014-06-12 6:48 ` Markus Armbruster
[not found] ` <87ppie1v4r.fsf@blackfin.pond.sub.org>
2014-06-12 7:44 ` Henning Schild
2014-06-12 9:31 ` Vincent JARDIN
2014-06-12 12:55 ` [Qemu-devel] " Markus Armbruster
2014-06-12 14:40 ` Why I advise against using ivshmem (was: [Qemu-devel] Using virtio for inter-VM communication) Markus Armbruster
[not found] ` <87vbs6qjhj.fsf_-_@blackfin.pond.sub.org>
2014-06-12 16:02 ` Why I advise against using ivshmem Vincent JARDIN
[not found] ` <5399CF09.8030803@6wind.com>
2014-06-12 16:54 ` Paolo Bonzini
2014-06-13 8:46 ` [Qemu-devel] " Markus Armbruster
2014-06-13 9:26 ` Vincent JARDIN
2014-06-13 9:31 ` Jobin Raju George
2014-06-13 9:48 ` Olivier MATZ
2014-06-13 10:09 ` Paolo Bonzini
2014-06-13 13:41 ` Vincent JARDIN
[not found] ` <539AFF7C.7090702@6wind.com>
2014-06-13 14:10 ` Paolo Bonzini
2014-06-14 18:01 ` Vincent JARDIN
2014-06-17 2:54 ` Stefan Hajnoczi
2014-06-17 9:03 ` David Marchand
[not found] ` <53A00464.8090609@6wind.com>
2014-06-17 9:44 ` Paolo Bonzini
2014-06-18 10:48 ` Stefan Hajnoczi
2014-06-18 14:57 ` David Marchand
2014-06-18 15:01 ` Andreas Färber
[not found] ` <53A1A9D9.6010908@suse.de>
2014-06-19 8:25 ` David Marchand
[not found] ` <53A1A8BE.3000801@6wind.com>
2014-06-18 15:10 ` Paolo Bonzini [this message]
2014-06-21 9:34 ` Stefan Hajnoczi
2014-06-26 20:02 ` Cam Macdonell
2014-06-30 11:10 ` Markus Armbruster
2014-06-18 10:51 ` Stefan Hajnoczi
2014-06-18 14:58 ` David Marchand
2014-06-13 9:29 ` Jobin Raju George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1ABD4.3000607@redhat.com \
--to=pbonzini@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=david.marchand@6wind.com \
--cc=henning.schild@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=olivier.matz@6wind.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thomas.monjalon@6wind.com \
--cc=vincent.jardin@6wind.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).