From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC 2/2] vhost: support urgent descriptors
Date: Sat, 20 Sep 2014 12:00:27 +0200 [thread overview]
Message-ID: <541D503B.3070507@redhat.com> (raw)
In-Reply-To: <541BD6E9.2010707@redhat.com>
Il 19/09/2014 09:10, Jason Wang ha scritto:
>> >
>> > - if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
>> > + if (vq->urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
> So the urgent descriptor only work when event index was not enabled?
> This seems suboptimal, we may still want to benefit from event index
> even if urgent descriptor is used. Looks like we need return true here
> when vq->urgent is true?
Its ||, not &&.
Without event index, all descriptors are treated as urgent.
Paolo
next prev parent reply other threads:[~2014-09-20 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 10:49 [PATCH RFC 1/2] virtio: support for urgent descriptors Michael S. Tsirkin
2014-07-01 10:49 ` [PATCH RFC 2/2] vhost: support " Michael S. Tsirkin
2014-09-19 7:10 ` Jason Wang
2014-09-20 10:00 ` Paolo Bonzini [this message]
2014-09-22 3:30 ` Jason Wang
2014-09-22 6:55 ` Michael S. Tsirkin
2014-09-22 9:55 ` Jason Wang
2014-09-22 11:24 ` Michael S. Tsirkin
2014-09-19 10:35 ` Jason Wang
2014-07-09 0:28 ` [PATCH RFC 1/2] virtio: support for " Rusty Russell
2014-09-21 8:10 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541D503B.3070507@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).