From: Sasha Levin <sasha.levin@oracle.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, andre.przywara@arm.com,
will.deacon@arm.com, josh@joshtriplett.org,
virtualization@lists.linux-foundation.org, penberg@kernel.org
Subject: Re: [RFC] kvmtool: add support for modern virtio-pci
Date: Thu, 19 Nov 2015 08:41:12 -0500 [thread overview]
Message-ID: <564DD178.9010904@oracle.com> (raw)
In-Reply-To: <1447917670.25140.3.camel@redhat.com>
On 11/19/2015 02:21 AM, Gerd Hoffmann wrote:
> On Mi, 2015-11-18 at 23:01 -0500, Sasha Levin wrote:
>> On 11/18/2015 11:00 PM, Sasha Levin wrote:
>>> Anyways, I debugged it for a bit a found that seabios attempts to write to
>>> the notification BAR, I look further tomorrow to narrow it down and fix it.
>>
>> Err, *read*, obviously.
>>
>> I've never implemented that because the kernel doesn't try to do that (it doesn't
>> make much sense, I think...).
>
> It doesn't make sense indeed (kvmtool still shouldn't segfault though),
> and on a quick look I can't spot a place in seabios doing that ...
>
> It's reading ISR, as part of device reset, to make sure any pending
> interrupts are cleared.
That was indeed the ISR field. Fixing that makes seabios reach the same point as
legacy virtio before failing.
I don't see the original correspondence about seabios failures you've reported, if
you want to forward them over we can look at it further.
Thanks,
Sasha
next prev parent reply other threads:[~2015-11-19 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 5:11 [RFC] kvmtool: add support for modern virtio-pci Sasha Levin
2015-11-18 8:22 ` Gerd Hoffmann
[not found] ` <1447834972.23726.92.camel@redhat.com>
2015-11-18 15:23 ` Sasha Levin
2015-11-18 17:52 ` Gerd Hoffmann
[not found] ` <1447869140.23691.15.camel@redhat.com>
2015-11-19 4:00 ` Sasha Levin
2015-11-19 4:01 ` Sasha Levin
2015-11-19 7:21 ` Gerd Hoffmann
[not found] ` <1447917670.25140.3.camel@redhat.com>
2015-11-19 13:41 ` Sasha Levin [this message]
2015-11-19 14:55 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DD178.9010904@oracle.com \
--to=sasha.levin@oracle.com \
--cc=andre.przywara@arm.com \
--cc=josh@joshtriplett.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=penberg@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).