* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper [not found] ` <bbe52a89-c7ea-c155-6226-0397f223cd80@linux.alibaba.com> @ 2021-07-16 12:53 ` David Hildenbrand 2021-07-16 13:10 ` David Hildenbrand 2021-07-19 3:46 ` Jason Wang 1 sibling, 1 reply; 4+ messages in thread From: David Hildenbrand @ 2021-07-16 12:53 UTC (permalink / raw) To: tianxianting, Xianting Tian, mst, jasowang; +Cc: linux-kernel, virtualization On 16.07.21 14:46, tianxianting wrote: > Do you interest in this patch? just little improvment:) I am, especially when I'm cc'ed and aware of it ;) Reviewed-by: David Hildenbrand <david@redhat.com> One nit below > > 在 2021/7/13 下午11:38, Xianting Tian 写道: >> From: Xianting Tian <xianting.tian@linux.alibaba.com> >> >> Use the helper virtio_find_vqs(). >> >> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> >> --- >> drivers/virtio/virtio_balloon.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c >> index 510e931..18e0bf3 100644 >> --- a/drivers/virtio/virtio_balloon.c >> +++ b/drivers/virtio/virtio_balloon.c >> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb) >> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack; >> } >> >> - err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, >> - vqs, callbacks, names, NULL, NULL); >> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, >> + callbacks, names, NULL); ^ we tend to indent this such that it is aligned with the line above (see the old code), unless the code becomes unreadable -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper 2021-07-16 12:53 ` [PATCH] virtio-balloon: Use virtio_find_vqs() helper David Hildenbrand @ 2021-07-16 13:10 ` David Hildenbrand 0 siblings, 0 replies; 4+ messages in thread From: David Hildenbrand @ 2021-07-16 13:10 UTC (permalink / raw) To: tianxianting, Xianting Tian, mst, jasowang; +Cc: linux-kernel, virtualization On 16.07.21 14:53, David Hildenbrand wrote: > On 16.07.21 14:46, tianxianting wrote: >> Do you interest in this patch? just little improvment:) > > I am, especially when I'm cc'ed and aware of it ;) > Sorry, just found it in my gmail spam folder ... WTH. Why does the original one get filtered but not your ping ... -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper [not found] ` <bbe52a89-c7ea-c155-6226-0397f223cd80@linux.alibaba.com> 2021-07-16 12:53 ` [PATCH] virtio-balloon: Use virtio_find_vqs() helper David Hildenbrand @ 2021-07-19 3:46 ` Jason Wang [not found] ` <d1b6f3d5-22a0-f0a5-ed49-1523dd740ffb@linux.alibaba.com> 1 sibling, 1 reply; 4+ messages in thread From: Jason Wang @ 2021-07-19 3:46 UTC (permalink / raw) To: tianxianting, Xianting Tian, mst, david; +Cc: linux-kernel, virtualization 在 2021/7/16 下午8:46, tianxianting 写道: > Do you interest in this patch? just little improvment:) > > 在 2021/7/13 下午11:38, Xianting Tian 写道: >> From: Xianting Tian <xianting.tian@linux.alibaba.com> >> >> Use the helper virtio_find_vqs(). >> >> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> >> --- >> drivers/virtio/virtio_balloon.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/virtio/virtio_balloon.c >> b/drivers/virtio/virtio_balloon.c >> index 510e931..18e0bf3 100644 >> --- a/drivers/virtio/virtio_balloon.c >> +++ b/drivers/virtio/virtio_balloon.c >> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb) >> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack; >> } >> - err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, >> - vqs, callbacks, names, NULL, NULL); >> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, >> + callbacks, names, NULL); >> if (err) >> return err; > Acked-by: Jason Wang <jasowang@redhat.com> Maybe it's better to convert all the drivers that doesn't use virtio_find_vqs{_ctx}. Thanks _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <d1b6f3d5-22a0-f0a5-ed49-1523dd740ffb@linux.alibaba.com>]
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper [not found] ` <d1b6f3d5-22a0-f0a5-ed49-1523dd740ffb@linux.alibaba.com> @ 2021-07-20 2:41 ` Jason Wang 0 siblings, 0 replies; 4+ messages in thread From: Jason Wang @ 2021-07-20 2:41 UTC (permalink / raw) To: tianxianting, Xianting Tian, mst, david; +Cc: linux-kernel, virtualization 在 2021/7/19 下午12:22, tianxianting 写道: > thanks, > > I checked, actually all virtio drivers have switched to use the helper > after this one merged. Ok. Cool. Thanks > > 在 2021/7/19 上午11:46, Jason Wang 写道: >> >> 在 2021/7/16 下午8:46, tianxianting 写道: >>> Do you interest in this patch? just little improvment:) >>> >>> 在 2021/7/13 下午11:38, Xianting Tian 写道: >>>> From: Xianting Tian <xianting.tian@linux.alibaba.com> >>>> >>>> Use the helper virtio_find_vqs(). >>>> >>>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> >>>> --- >>>> drivers/virtio/virtio_balloon.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/virtio/virtio_balloon.c >>>> b/drivers/virtio/virtio_balloon.c >>>> index 510e931..18e0bf3 100644 >>>> --- a/drivers/virtio/virtio_balloon.c >>>> +++ b/drivers/virtio/virtio_balloon.c >>>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb) >>>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack; >>>> } >>>> - err = vb->vdev->config->find_vqs(vb->vdev, >>>> VIRTIO_BALLOON_VQ_MAX, >>>> - vqs, callbacks, names, NULL, NULL); >>>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, >>>> + callbacks, names, NULL); >>>> if (err) >>>> return err; >>> >> >> Acked-by: Jason Wang <jasowang@redhat.com> >> >> Maybe it's better to convert all the drivers that doesn't use >> virtio_find_vqs{_ctx}. >> >> Thanks > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-20 2:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1626190724-7942-1-git-send-email-xianting_tian@126.com>
[not found] ` <bbe52a89-c7ea-c155-6226-0397f223cd80@linux.alibaba.com>
2021-07-16 12:53 ` [PATCH] virtio-balloon: Use virtio_find_vqs() helper David Hildenbrand
2021-07-16 13:10 ` David Hildenbrand
2021-07-19 3:46 ` Jason Wang
[not found] ` <d1b6f3d5-22a0-f0a5-ed49-1523dd740ffb@linux.alibaba.com>
2021-07-20 2:41 ` Jason Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).