From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH v6 64/92] kvm: introspection: add single-stepping Date: Wed, 14 Aug 2019 14:53:46 +0200 Message-ID: <5851eb00-3d00-1213-99cb-7bab2da3ba89@redhat.com> References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-65-alazar@bitdefender.com> <20190812205038.GC1437@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Nicusor CITU , Sean Christopherson , =?UTF-8?Q?Adalbert_Laz=c4=83r?= Cc: Tamas K Lengyel , Weijiang Yang , "Zhang@linux.intel.com" , "kvm@vger.kernel.org" , Konrad Rzeszutek Wilk , Jan Kiszka , =?UTF-8?Q?Samuel_Laur=c3=a9n?= , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , "virtualization@lists.linux-foundation.org" , "linux-mm@kvack.org" , Patrick Colp , Mathieu Tarral , Yu C , Stefan Hajnoczi , =?UTF-8?Q?Mihai_Don=c8=9bu?= , Jim Mattson List-Id: virtualization@lists.linuxfoundation.org On 14/08/19 14:36, Nicusor CITU wrote: > Thank you for signaling this. This piece of code is leftover from the > initial attempt to make single step running. > Based on latest results, we do not actually need to change > interruptibility during the singlestep. It is enough to enable the MTF > and just suppress any interrupt injection (if any) before leaving the > vcpu entering in guest. > This is exactly what testcases are for... Paolo