From: Jason Wang <jasowang@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, joro@8bytes.org,
"Randy Dunlap" <rdunlap@infradead.org>,
iommu@lists.linux-foundation.org,
"Matthew Wilcox" <willy@infradead.org>,
virtualization <virtualization@lists.linux-foundation.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Christian Brauner" <christian.brauner@canonical.com>,
bcrl@kvack.org, "Al Viro" <viro@zeniv.linux.org.uk>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
linux-fsdevel@vger.kernel.org,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Mika Penttilä" <mika.penttila@nextfour.com>
Subject: Re: [PATCH v7 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace
Date: Thu, 27 May 2021 13:00:07 +0800 [thread overview]
Message-ID: <5a68bb7c-fd05-ce02-cd61-8a601055c604@redhat.com> (raw)
In-Reply-To: <CACycT3uAqa6azso_8MGreh+quj-JXO1piuGnrV8k2kTfc34N2g@mail.gmail.com>
在 2021/5/27 下午12:57, Yongji Xie 写道:
> On Thu, May 27, 2021 at 12:13 PM Jason Wang <jasowang@redhat.com> wrote:
>>
>> 在 2021/5/17 下午5:55, Xie Yongji 写道:
>>> +
>>> +static int vduse_dev_msg_sync(struct vduse_dev *dev,
>>> + struct vduse_dev_msg *msg)
>>> +{
>>> + init_waitqueue_head(&msg->waitq);
>>> + spin_lock(&dev->msg_lock);
>>> + vduse_enqueue_msg(&dev->send_list, msg);
>>> + wake_up(&dev->waitq);
>>> + spin_unlock(&dev->msg_lock);
>>> + wait_event_killable(msg->waitq, msg->completed);
>>
>> What happens if the userspace(malicous) doesn't give a response forever?
>>
>> It looks like a DOS. If yes, we need to consider a way to fix that.
>>
> How about using wait_event_killable_timeout() instead?
Probably, and then we need choose a suitable timeout and more important,
need to report the failure to virtio.
Thanks
>
> Thanks,
> Yongji
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-05-27 5:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210517095513.850-1-xieyongji@bytedance.com>
[not found] ` <20210517095513.850-5-xieyongji@bytedance.com>
[not found] ` <CACycT3s1rEvNnNkJKQsHGRsyLPADieFdVkb1Sp3GObR0Vox5Fg@mail.gmail.com>
2021-05-19 14:42 ` [PATCH v7 04/12] virtio-blk: Add validation for block size in config space Dan Carpenter
[not found] ` <CACycT3veubBFCg9omxLDJJFP7B7QH8++Q+tKmb_M_hmNS45cmw@mail.gmail.com>
2021-05-20 5:43 ` Michael S. Tsirkin
2021-05-20 6:06 ` [PATCH v7 00/12] Introduce VDUSE - vDPA Device in Userspace Michael S. Tsirkin
[not found] ` <CACycT3tKY2V=dmOJjeiZxkqA3cH8_KF93NNbRnNU04e5Job2cw@mail.gmail.com>
2021-05-25 6:40 ` Jason Wang
2021-05-25 6:48 ` Michael S. Tsirkin
2021-05-25 7:11 ` Jason Wang
[not found] ` <20210517095513.850-3-xieyongji@bytedance.com>
2021-05-20 6:18 ` [PATCH v7 02/12] file: Export receive_fd() to modules Al Viro
[not found] ` <20210517095513.850-2-xieyongji@bytedance.com>
2021-05-26 2:36 ` [PATCH v7 01/12] iova: Export alloc_iova_fast() Jason Wang
[not found] ` <20210517095513.850-6-xieyongji@bytedance.com>
2021-05-26 2:41 ` [PATCH v7 05/12] virtio_scsi: Add validation for residual bytes from response Jason Wang
[not found] ` <20210517095513.850-12-xieyongji@bytedance.com>
2021-05-20 6:28 ` [PATCH v7 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace Al Viro
2021-05-27 4:12 ` Jason Wang
[not found] ` <CACycT3uAqa6azso_8MGreh+quj-JXO1piuGnrV8k2kTfc34N2g@mail.gmail.com>
2021-05-27 5:00 ` Jason Wang [this message]
[not found] ` <CACycT3ve7YvKF+F+AnTQoJZMPua+jDvGMs_ox8GQe_=SGdeCMA@mail.gmail.com>
2021-05-27 5:40 ` Jason Wang
[not found] ` <CACycT3ufok97cKpk47NjUBTc0QAyfauFUyuFvhWKmuqCGJ7zZw@mail.gmail.com>
2021-05-27 8:41 ` Jason Wang
2021-05-27 8:43 ` Jason Wang
[not found] ` <CACycT3s6SkER09KL_Ns9d03quYSKOuZwd3=HJ_s1SL7eH7y5gA@mail.gmail.com>
2021-05-28 1:33 ` Jason Wang
[not found] ` <CACycT3vKZ3y0gga8PrSVtssZfNV0Y-A8=iYZSi9sbpHRNkVf-A@mail.gmail.com>
2021-05-28 6:38 ` Jason Wang
[not found] ` <CACycT3uK_Fuade-b8FVYkGCKZnne_UGGbYRFwv7WOH2oKCsXSg@mail.gmail.com>
2021-05-28 2:31 ` Jason Wang
[not found] ` <CACycT3tLj6a7-tbqO9SzCLStwYrOALdkfnt1jxQBv3s0VzD6AQ@mail.gmail.com>
2021-05-31 4:38 ` Jason Wang
2021-05-31 4:56 ` Greg KH
[not found] ` <CACycT3vRHPfOGxmy1Uv=8_dqqq8iG4YTZHUizo+y8EYKGS5g8g@mail.gmail.com>
2021-05-31 6:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a68bb7c-fd05-ce02-cd61-8a601055c604@redhat.com \
--to=jasowang@redhat.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=christian.brauner@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).