* Re: [PATCH] vhost-vdpa: fix bug-"v->vqs" and "v" don't free [not found] <20210618065307.183-1-caihuoqing@baidu.com> @ 2021-06-18 7:20 ` Jason Wang 0 siblings, 0 replies; only message in thread From: Jason Wang @ 2021-06-18 7:20 UTC (permalink / raw) To: Cai Huoqing, mst; +Cc: netdev, kvm, virtualization 在 2021/6/18 下午2:53, Cai Huoqing 写道: > "v->vqs" and "v" don't free when "cdev_device_add" returns error > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > --- > drivers/vhost/vdpa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index fb41db3da611..6e5d5df5ee70 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -1065,6 +1065,8 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa) > > err: > put_device(&v->dev); > + kfree(v->vqs); > + kfree(v); Isn't this the charge of vhost_vdpa_release_dev()? Thanks > return r; > } > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-18 7:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210618065307.183-1-caihuoqing@baidu.com>
2021-06-18 7:20 ` [PATCH] vhost-vdpa: fix bug-"v->vqs" and "v" don't free Jason Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).