virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Xin Li <xin@zytor.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	virtualization@lists.linux.dev
Cc: Ajay Kaher <ajay.kaher@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 5/6] x86/paravirt: Switch MSR access pv_ops functions to instruction interfaces
Date: Mon, 29 Sep 2025 13:07:41 +0200	[thread overview]
Message-ID: <5f6871b5-243c-457f-82f7-47246b6ef6ea@suse.com> (raw)
In-Reply-To: <6eb60b62-bd3a-4a64-9665-fc911cc7d869@suse.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1363 bytes --]

On 26.08.25 12:39, Jürgen Groß wrote:
> On 25.08.25 03:54, Xin Li wrote:
>> On 6/11/2025 5:58 AM, Juergen Gross wrote:
>>> I'm just doing a V2 of my series, but this time including the additional
>>> support of the non-serializing and immediate forms. Lets see how this will
>>> look like. I will drop using the EAX_EDX_* macros, but due to the reason
>>> mentioned above I won't switch to your variant completely.
>>
>> Hi Juergen,
>>
>> Do you have any update on this?
> 
> I've been very busy with other stuff (downstream, security, ...).
> 
> In between I've been working on the series. I hope to post it some time in
> September.

I have been working on this the last week.

Turns out things are a little bit complicated for adding them into the
paravirt framework, especially regarding the exception fixups.

I first thought that Peter's patch "x86/extable: Implement EX_TYPE_FUNC_REWIND"
would help, but I'm seeing problems with his approach in case of shadow stack
being enabled. This case would at least needed to be handled in his patch, as
otherwise shadow stack and normal stack could get out of sync.

For this reason your patch series won't work easily, too.

OTOH using your basic idea it seems to be possible to solve the fixup problem
without needing Peter's patch. I'm working on that approach now.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

  reply	other threads:[~2025-09-29 11:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06  9:20 [PATCH 0/6] x86/msr: let paravirt inline rdmsr/wrmsr instructions Juergen Gross
2025-05-06  9:20 ` [PATCH 4/6] x86/msr: Move MSR trace calls one function level up Juergen Gross
2025-05-06  9:20 ` [PATCH 5/6] x86/paravirt: Switch MSR access pv_ops functions to instruction interfaces Juergen Gross
2025-05-09  8:18   ` Xin Li
2025-05-12 11:20     ` Jürgen Groß
2025-05-12 11:24       ` Juergen Gross
2025-05-13  5:55         ` Xin Li
2025-05-13  6:06           ` Jürgen Groß
2025-05-13  6:55             ` Xin Li
2025-05-13 22:24             ` H. Peter Anvin
2025-05-15  7:32               ` Xin Li
2025-05-15 20:24                 ` H. Peter Anvin
2025-05-13  7:44       ` Xin Li
2025-06-11 12:58         ` Juergen Gross
2025-06-13  7:31           ` Xin Li
2025-06-13  8:01             ` Jürgen Groß
2025-08-25  1:54           ` Xin Li
2025-08-26 10:39             ` Jürgen Groß
2025-09-29 11:07               ` Juergen Gross [this message]
2025-05-10 16:03 ` [PATCH 0/6] x86/msr: let paravirt inline rdmsr/wrmsr instructions Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f6871b5-243c-457f-82f7-47246b6ef6ea@suse.com \
    --to=jgross@suse.com \
    --cc=ajay.kaher@broadcom.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux.dev \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).