From: Amit Shah <amit@infradead.org>
To: "Cédric Le Goater" <clg@kaod.org>, "Amit Shah" <amit@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] virtio_console: Introduce an ID allocator for virtual console numbers
Date: Tue, 22 Nov 2022 18:03:05 +0100 [thread overview]
Message-ID: <6293fd7d415950979c55c3f09254a6f52eba708b.camel@infradead.org> (raw)
In-Reply-To: <20221114173811.1977367-1-clg@kaod.org>
On Mon, 2022-11-14 at 18:38 +0100, Cédric Le Goater wrote:
> When a virtio console port is initialized, it is registered as an hvc
> console using a virtual console number. If a KVM guest is started with
> multiple virtio console devices, the same vtermno (or virtual console
> number) can be used to allocate different hvc consoles, which leads to
> various communication problems later on.
>
> This is also reported in debugfs :
>
> # grep vtermno /sys/kernel/debug/virtio-ports/*
> /sys/kernel/debug/virtio-ports/vport1p1:console_vtermno: 1
> /sys/kernel/debug/virtio-ports/vport2p1:console_vtermno: 1
> /sys/kernel/debug/virtio-ports/vport3p1:console_vtermno: 2
> /sys/kernel/debug/virtio-ports/vport4p1:console_vtermno: 3
>
> Replace the next_vtermno global with an ID allocator and start the
> allocation at 1 as it is today. Also recycle IDs when a console port
> is removed.
When the original virtio_console module was written, it didn't have
support for multiple ports to be used this way. So the oddity you're
seeing is left there deliberately: VMMs should not be instantiating
console ports this way.
I don't know if we should take in this change, but can you walk through
all combinations of new/old guest and new/old hypervisor and ensure
nothing's going to break -- and confirm with the spec this is still OK
to do? It may not be a goal to still ensure launches of a new guest on
a very old (say) Centos5 guest still works -- but that was the point of
maintaining backward compat...
Amit
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-11-22 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221114173811.1977367-1-clg@kaod.org>
2022-11-22 11:12 ` [PATCH v2] virtio_console: Introduce an ID allocator for virtual console numbers Thomas Huth
2022-11-22 17:03 ` Amit Shah [this message]
[not found] ` <62cfdcff-9323-5007-67e2-54178e43b21e@kaod.org>
2022-11-23 10:36 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6293fd7d415950979c55c3f09254a6f52eba708b.camel@infradead.org \
--to=amit@infradead.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=clg@kaod.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).