From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net: fix mergeable bufs error handling
Date: Thu, 30 Mar 2017 11:59:21 +0800 [thread overview]
Message-ID: <67f7d42f-7ab5-10f4-80b2-83044ae1048b@redhat.com> (raw)
In-Reply-To: <1490791050-22046-1-git-send-email-mst@redhat.com>
On 2017年03月29日 20:37, Michael S. Tsirkin wrote:
> On xdp error we try to free head_skb without having
> initialized it, that's clearly bogus.
>
> Fixes: f600b6905015 ("virtio_net: Add XDP support")
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 11773d6..e0fb3707 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
> u16 num_buf;
> struct page *page;
> int offset;
> - struct sk_buff *head_skb, *curr_skb;
> + struct sk_buff *head_skb = NULL, *curr_skb;
> struct bpf_prog *xdp_prog;
> unsigned int truesize;
>
My tree (net.git HEAD is 8f1f7eeb22c16a197159cf7b35d1350695193ead) has:
head_skb = NULL;
just after the above codes.
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2017-03-30 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1490791050-22046-1-git-send-email-mst@redhat.com>
2017-03-30 3:59 ` Jason Wang [this message]
2017-03-30 17:57 ` [PATCH] virtio_net: fix mergeable bufs error handling David Miller
2017-03-29 12:37 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f7d42f-7ab5-10f4-80b2-83044ae1048b@redhat.com \
--to=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).