From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: Juergen Gross <jgross@suse.com>, Mike Galbraith <efault@gmx.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
live-patching@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
xen-devel@lists.xenproject.org,
Thomas Gleixner <tglx@linutronix.de>,
Sasha Levin <alexander.levin@verizon.com>,
Jiri Slaby <jslaby@suse.cz>, Alok Kataria <akataria@vmware.com>
Subject: Re: [Xen-devel] [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure
Date: Tue, 17 Oct 2017 10:05:47 -0400 [thread overview]
Message-ID: <6f2a54e3-84f7-c04b-ae3c-cad6969d6652@oracle.com> (raw)
In-Reply-To: <CAMzpN2j_6KzT22nLmYMM3RDxF0UkSQXCisb6umBka0T2ZHwDpQ@mail.gmail.com>
On 10/17/2017 09:10 AM, Brian Gerst wrote:
> On Mon, Oct 16, 2017 at 2:18 PM, Boris Ostrovsky
> <boris.ostrovsky@oracle.com> wrote:
>>
>> Replacing the macro with
>>
>> #define PV_INDIRECT(addr) *addr // well, it's not so much
>> indirect anymore
>>
>> makes things work. Or maybe it can be adjusted top be kept truly indirect.
> That is still an indirect call, just using absolute addressing for the
> pointer instead of RIP-relative.
Oh, right, I've got my terminology all wrong.
-boris
> Alternatives has very limited
> relocation capabilities. It will only handle a single call or jmp
> replacement. Using absolute addressing is slightly less efficient
> (takes one extra byte to encode, and needs a relocation for KASLR),
> but it works just as well. You could also relocate the instruction
> manually by adding the delta between the original and replacement code
> to the displacement.
next prev parent reply other threads:[~2017-10-17 14:05 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1507128293.git.jpoimboe@redhat.com>
2017-10-04 15:58 ` [PATCH 01/13] x86/paravirt: remove wbinvd() paravirt interface Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 02/13] x86/paravirt: Fix output constraint macro names Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 04/13] x86/paravirt: Convert DEF_NATIVE macro to GCC extended asm syntax Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 05/13] x86/paravirt: Move paravirt asm macros to paravirt-asm.h Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 06/13] x86/paravirt: Clean up paravirt-asm.h Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 07/13] x86/paravirt: Simplify ____PVOP_CALL() Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 08/13] x86/paravirt: Clean up paravirt_types.h Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 09/13] x86/asm: Convert ALTERNATIVE*() assembler macros to preprocessor macros Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 10/13] x86/alternative: Support indirect call replacement Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 12/13] objtool: Add support for new .pv_altinstructions section Josh Poimboeuf
2017-10-04 15:58 ` [PATCH 13/13] x86/paravirt: Convert natively patched pv ops to use paravirt alternatives Josh Poimboeuf
[not found] ` <39743c79546ede3073586403d0836a4f93519b0a.1507128293.git.jpoimboe@redhat.com>
2017-10-05 20:35 ` [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure Boris Ostrovsky
2017-10-06 14:32 ` Josh Poimboeuf
[not found] ` <20171006143259.rs3zh7k5tmsgesqy@treble>
2017-10-06 15:29 ` Boris Ostrovsky
2017-10-06 16:30 ` Josh Poimboeuf
2017-10-12 19:11 ` Boris Ostrovsky
2017-10-12 19:27 ` [Xen-devel] " Andrew Cooper
2017-10-12 19:53 ` Boris Ostrovsky
2017-10-16 18:18 ` Boris Ostrovsky
2017-10-17 5:24 ` Josh Poimboeuf
2017-10-17 13:10 ` Brian Gerst
[not found] ` <20171017052413.nzbqniurzw7eim4b@treble>
2017-10-17 13:58 ` Boris Ostrovsky
2017-10-17 14:36 ` Josh Poimboeuf
[not found] ` <20171017143613.6i7auk3mqcqayx3o@treble>
2017-10-17 15:36 ` Boris Ostrovsky
2017-10-17 20:17 ` Josh Poimboeuf
[not found] ` <20171017201743.tnw6wulu4gjvkqli@treble>
2017-10-17 20:36 ` Boris Ostrovsky
2017-10-17 20:50 ` Josh Poimboeuf
[not found] ` <20171017205037.rnqto2i2hul4q2s4@treble>
2017-10-17 20:59 ` Boris Ostrovsky
2017-10-17 21:03 ` Josh Poimboeuf
[not found] ` <CAMzpN2j_6KzT22nLmYMM3RDxF0UkSQXCisb6umBka0T2ZHwDpQ@mail.gmail.com>
2017-10-17 14:05 ` Boris Ostrovsky [this message]
2017-10-06 7:35 ` [Xen-devel] [PATCH 00/13] x86/paravirt: Make pv ops code generation more closely match reality Vitaly Kuznetsov
[not found] ` <87bmlkiv9n.fsf@vitty.brq.redhat.com>
2017-10-06 14:36 ` Josh Poimboeuf
[not found] ` <3f9bf17f6372ee92d984f6c7fd13e0cb14bc0e0a.1507128293.git.jpoimboe@redhat.com>
2017-10-24 13:17 ` [PATCH 01/13] x86/paravirt: remove wbinvd() paravirt interface Juergen Gross
2017-11-17 14:39 ` Borislav Petkov
[not found] ` <f8aad6bc7bcdb606b89f3d5dc5fb2303019cb3d0.1507128293.git.jpoimboe@redhat.com>
2017-10-25 9:33 ` [PATCH 02/13] x86/paravirt: Fix output constraint macro names Juergen Gross
[not found] ` <5d2799f9-fb5d-381e-a576-15098626201f@suse.com>
2017-11-16 20:50 ` Josh Poimboeuf
2017-11-17 6:55 ` Juergen Gross
[not found] ` <e4cea2b8aa8ca23122d9c807784ca62ee6cbbff8.1507128293.git.jpoimboe@redhat.com>
2017-10-25 9:46 ` [PATCH 03/13] x86/paravirt: Convert native patch assembly code strings to macros Juergen Gross
[not found] ` <a1c4f192-f141-7488-ae6e-ad07101ba8da@suse.com>
2017-11-16 21:04 ` Josh Poimboeuf
2017-11-17 18:07 ` Borislav Petkov
2017-11-17 19:10 ` Juergen Gross
2017-11-17 19:42 ` Josh Poimboeuf
2017-11-18 10:20 ` Juergen Gross
2017-11-18 13:17 ` Josh Poimboeuf
[not found] ` <fc26aa39d00294fce9f669ea4757135ac02eae0a.1507128293.git.jpoimboe@redhat.com>
2017-10-25 10:03 ` [PATCH 04/13] x86/paravirt: Convert DEF_NATIVE macro to GCC extended asm syntax Juergen Gross
[not found] ` <4ce3349e19c5ea443cb33f76468adddcee685f89.1507128293.git.jpoimboe@redhat.com>
2017-10-25 10:32 ` [PATCH 05/13] x86/paravirt: Move paravirt asm macros to paravirt-asm.h Juergen Gross
[not found] ` <d76cfb9e80bc974fe24f88098f1aecd8c11fdf29.1507128293.git.jpoimboe@redhat.com>
2017-10-25 10:59 ` [PATCH 06/13] x86/paravirt: Clean up paravirt-asm.h Juergen Gross
[not found] ` <e09e6cb4f4717fc6d81ddb5fc38cd45504348ce1.1507128293.git.jpoimboe@redhat.com>
2017-10-25 11:01 ` [PATCH 07/13] x86/paravirt: Simplify ____PVOP_CALL() Juergen Gross
2017-11-22 16:35 ` Borislav Petkov
[not found] ` <38b16ecbfa88b41239e8a87ce1d8330fea7a2b3a.1507128293.git.jpoimboe@redhat.com>
2017-10-25 11:08 ` [PATCH 08/13] x86/paravirt: Clean up paravirt_types.h Juergen Gross
2017-11-22 20:46 ` Borislav Petkov
[not found] ` <9e97ee7a68cab00993c7afa8e429fd8fe5a7015f.1507128293.git.jpoimboe@redhat.com>
2017-10-25 11:14 ` [PATCH 09/13] x86/asm: Convert ALTERNATIVE*() assembler macros to preprocessor macros Juergen Gross
[not found] ` <efabcfb022d29fb0a9ccb39380623573555c2bcb.1507128293.git.jpoimboe@redhat.com>
2017-10-25 11:25 ` [PATCH 10/13] x86/alternative: Support indirect call replacement Juergen Gross
[not found] ` <c57fb310-141b-2262-7e17-bf37d3afdf82@suse.com>
2017-11-16 21:19 ` Josh Poimboeuf
2017-11-17 5:46 ` Juergen Gross
2017-11-17 19:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2a54e3-84f7-c04b-ae3c-cad6969d6652@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=akataria@vmware.com \
--cc=alexander.levin@verizon.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).