From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre Morel <pmorel@linux.ibm.com>
Subject: Re: [PATCH 08/10] virtio/s390: add indirection to indicators access
Date: Wed, 8 May 2019 16:31:35 +0200
Message-ID: <716d47ca-016f-e8f4-6d78-7746a7d9f6ba@linux.ibm.com>
References: <20190426183245.37939-1-pasic@linux.ibm.com>
	<20190426183245.37939-9-pasic@linux.ibm.com>
Reply-To: pmorel@linux.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <20190426183245.37939-9-pasic@linux.ibm.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: Halil Pasic <pasic@linux.ibm.com>, kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Sebastian Ott <sebott@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, Janosch Frank <frankja@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Farhan Ali <alifm@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, virtualization@lists.linux-foundation.org, Christoph Hellwig <hch@infradead.org>, Viktor Mihajlovski <mihajlov@linux.ibm.com>
List-Id: virtualization@lists.linuxfoundation.org

T24gMjYvMDQvMjAxOSAyMDozMiwgSGFsaWwgUGFzaWMgd3JvdGU6Cj4gVGhpcyB3aWxsIGNvbWUg
aW4gaGFuZHkgc29vbiB3aGVuIHdlIHB1bGwgb3V0IHRoZSBpbmRpY2F0b3JzIGZyb20KPiB2aXJ0
aW9fY2N3X2RldmljZSB0byBhIG1lbW9yeSBhcmVhIHRoYXQgaXMgc2hhcmVkIHdpdGggdGhlIGh5
cGVydmlzb3IKPiAoaW4gcGFydGljdWxhciBmb3IgcHJvdGVjdGVkIHZpcnR1YWxpemF0aW9uIGd1
ZXN0cykuCj4gCj4gU2lnbmVkLW9mZi1ieTogSGFsaWwgUGFzaWMgPHBhc2ljQGxpbnV4LmlibS5j
b20+Cj4gLS0tCj4gICBkcml2ZXJzL3MzOTAvdmlydGlvL3ZpcnRpb19jY3cuYyB8IDQwICsrKysr
KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAy
NSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9zMzkwL3ZpcnRpby92aXJ0aW9fY2N3LmMgYi9kcml2ZXJzL3MzOTAvdmlydGlvL3ZpcnRpb19j
Y3cuYwo+IGluZGV4IGJiN2E5MjMxNmZjOC4uMWYzZTdkNTY5MjRmIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvczM5MC92aXJ0aW8vdmlydGlvX2Njdy5jCj4gKysrIGIvZHJpdmVycy9zMzkwL3ZpcnRp
by92aXJ0aW9fY2N3LmMKPiBAQCAtNjgsNiArNjgsMTYgQEAgc3RydWN0IHZpcnRpb19jY3dfZGV2
aWNlIHsKPiAgIAl2b2lkICphaXJxX2luZm87Cj4gICB9Owo+ICAgCj4gK3N0YXRpYyBpbmxpbmUg
dW5zaWduZWQgbG9uZyAqaW5kaWNhdG9ycyhzdHJ1Y3QgdmlydGlvX2Njd19kZXZpY2UgKnZjZGV2
KQo+ICt7Cj4gKwlyZXR1cm4gJnZjZGV2LT5pbmRpY2F0b3JzOwo+ICt9Cj4gKwo+ICtzdGF0aWMg
aW5saW5lIHVuc2lnbmVkIGxvbmcgKmluZGljYXRvcnMyKHN0cnVjdCB2aXJ0aW9fY2N3X2Rldmlj
ZSAqdmNkZXYpCj4gK3sKPiArCXJldHVybiAmdmNkZXYtPmluZGljYXRvcnMyOwo+ICt9Cj4gKwo+
ICAgc3RydWN0IHZxX2luZm9fYmxvY2tfbGVnYWN5IHsKPiAgIAlfX3U2NCBxdWV1ZTsKPiAgIAlf
X3UzMiBhbGlnbjsKPiBAQCAtMzM3LDE3ICszNDcsMTcgQEAgc3RhdGljIHZvaWQgdmlydGlvX2Nj
d19kcm9wX2luZGljYXRvcihzdHJ1Y3QgdmlydGlvX2Njd19kZXZpY2UgKnZjZGV2LAo+ICAgCQlj
Y3ctPmNkYSA9IChfX3UzMikodW5zaWduZWQgbG9uZykgdGhpbmludF9hcmVhOwo+ICAgCX0gZWxz
ZSB7Cj4gICAJCS8qIHBheWxvYWQgaXMgdGhlIGFkZHJlc3Mgb2YgdGhlIGluZGljYXRvcnMgKi8K
PiAtCQlpbmRpY2F0b3JwID0ga21hbGxvYyhzaXplb2YoJnZjZGV2LT5pbmRpY2F0b3JzKSwKPiAr
CQlpbmRpY2F0b3JwID0ga21hbGxvYyhzaXplb2YoaW5kaWNhdG9ycyh2Y2RldikpLAo+ICAgCQkJ
CSAgICAgR0ZQX0RNQSB8IEdGUF9LRVJORUwpOwo+ICAgCQlpZiAoIWluZGljYXRvcnApCj4gICAJ
CQlyZXR1cm47Cj4gICAJCSppbmRpY2F0b3JwID0gMDsKPiAgIAkJY2N3LT5jbWRfY29kZSA9IEND
V19DTURfU0VUX0lORDsKPiAtCQljY3ctPmNvdW50ID0gc2l6ZW9mKCZ2Y2Rldi0+aW5kaWNhdG9y
cyk7Cj4gKwkJY2N3LT5jb3VudCA9IHNpemVvZihpbmRpY2F0b3JzKHZjZGV2KSk7CgpUaGlzIGxv
b2tzIHN0cmFuZ2UgdG8gbWUuIFdhcyBhbHJlYWR5IHdlaXJkIGJlZm9yZS4KTHVja3kgd2UgYXJl
IGluZGljYXRvcnMgYXJlIGxvbmcuLi4KbWF5IGJlIGp1c3Qgc2l6ZW9mKGxvbmcpCgo+ICAgCQlj
Y3ctPmNkYSA9IChfX3UzMikodW5zaWduZWQgbG9uZykgaW5kaWNhdG9ycDsKPiAgIAl9Cj4gICAJ
LyogRGVyZWdpc3RlciBpbmRpY2F0b3JzIGZyb20gaG9zdC4gKi8KPiAtCXZjZGV2LT5pbmRpY2F0
b3JzID0gMDsKPiArCSppbmRpY2F0b3JzKHZjZGV2KSA9IDA7Cj4gICAJY2N3LT5mbGFncyA9IDA7
Cj4gICAJcmV0ID0gY2N3X2lvX2hlbHBlcih2Y2RldiwgY2N3LAo+ICAgCQkJICAgIHZjZGV2LT5p
c190aGluaW50ID8KPiBAQCAtNjU2LDEwICs2NjYsMTAgQEAgc3RhdGljIGludCB2aXJ0aW9fY2N3
X2ZpbmRfdnFzKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2LCB1bnNpZ25lZCBudnFzLAo+ICAg
CSAqIFdlIG5lZWQgYSBkYXRhIGFyZWEgdW5kZXIgMkcgdG8gY29tbXVuaWNhdGUuIE91ciBwYXls
b2FkIGlzCj4gICAJICogdGhlIGFkZHJlc3Mgb2YgdGhlIGluZGljYXRvcnMuCj4gICAJKi8KPiAt
CWluZGljYXRvcnAgPSBrbWFsbG9jKHNpemVvZigmdmNkZXYtPmluZGljYXRvcnMpLCBHRlBfRE1B
IHwgR0ZQX0tFUk5FTCk7Cj4gKwlpbmRpY2F0b3JwID0ga21hbGxvYyhzaXplb2YoaW5kaWNhdG9y
cyh2Y2RldikpLCBHRlBfRE1BIHwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKCFpbmRpY2F0b3JwKQo+
ICAgCQlnb3RvIG91dDsKPiAtCSppbmRpY2F0b3JwID0gKHVuc2lnbmVkIGxvbmcpICZ2Y2Rldi0+
aW5kaWNhdG9yczsKPiArCSppbmRpY2F0b3JwID0gKHVuc2lnbmVkIGxvbmcpIGluZGljYXRvcnMo
dmNkZXYpOwo+ICAgCWlmICh2Y2Rldi0+aXNfdGhpbmludCkgewo+ICAgCQlyZXQgPSB2aXJ0aW9f
Y2N3X3JlZ2lzdGVyX2FkYXB0ZXJfaW5kKHZjZGV2LCB2cXMsIG52cXMsIGNjdyk7Cj4gICAJCWlm
IChyZXQpCj4gQEAgLTY2OCwyMSArNjc4LDIxIEBAIHN0YXRpYyBpbnQgdmlydGlvX2Njd19maW5k
X3ZxcyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldiwgdW5zaWduZWQgbnZxcywKPiAgIAl9Cj4g
ICAJaWYgKCF2Y2Rldi0+aXNfdGhpbmludCkgewo+ICAgCQkvKiBSZWdpc3RlciBxdWV1ZSBpbmRp
Y2F0b3JzIHdpdGggaG9zdC4gKi8KPiAtCQl2Y2Rldi0+aW5kaWNhdG9ycyA9IDA7Cj4gKwkJKmlu
ZGljYXRvcnModmNkZXYpID0gMDsKPiAgIAkJY2N3LT5jbWRfY29kZSA9IENDV19DTURfU0VUX0lO
RDsKPiAgIAkJY2N3LT5mbGFncyA9IDA7Cj4gLQkJY2N3LT5jb3VudCA9IHNpemVvZigmdmNkZXYt
PmluZGljYXRvcnMpOwo+ICsJCWNjdy0+Y291bnQgPSBzaXplb2YoaW5kaWNhdG9ycyh2Y2Rldikp
OwoKc2FtZSBhcyBiZWZvcmUKCj4gICAJCWNjdy0+Y2RhID0gKF9fdTMyKSh1bnNpZ25lZCBsb25n
KSBpbmRpY2F0b3JwOwo+ICAgCQlyZXQgPSBjY3dfaW9faGVscGVyKHZjZGV2LCBjY3csIFZJUlRJ
T19DQ1dfRE9JTkdfU0VUX0lORCk7Cj4gICAJCWlmIChyZXQpCj4gICAJCQlnb3RvIG91dDsKPiAg
IAl9Cj4gICAJLyogUmVnaXN0ZXIgaW5kaWNhdG9yczIgd2l0aCBob3N0IGZvciBjb25maWcgY2hh
bmdlcyAqLwo+IC0JKmluZGljYXRvcnAgPSAodW5zaWduZWQgbG9uZykgJnZjZGV2LT5pbmRpY2F0
b3JzMjsKPiAtCXZjZGV2LT5pbmRpY2F0b3JzMiA9IDA7Cj4gKwkqaW5kaWNhdG9ycCA9ICh1bnNp
Z25lZCBsb25nKSBpbmRpY2F0b3JzMih2Y2Rldik7Cj4gKwkqaW5kaWNhdG9yczIodmNkZXYpID0g
MDsKPiAgIAljY3ctPmNtZF9jb2RlID0gQ0NXX0NNRF9TRVRfQ09ORl9JTkQ7Cj4gICAJY2N3LT5m
bGFncyA9IDA7Cj4gLQljY3ctPmNvdW50ID0gc2l6ZW9mKCZ2Y2Rldi0+aW5kaWNhdG9yczIpOwo+
ICsJY2N3LT5jb3VudCA9IHNpemVvZihpbmRpY2F0b3JzMih2Y2RldikpOwoKaGVyZSB0b28KCj4g
ICAJY2N3LT5jZGEgPSAoX191MzIpKHVuc2lnbmVkIGxvbmcpIGluZGljYXRvcnA7Cj4gICAJcmV0
ID0gY2N3X2lvX2hlbHBlcih2Y2RldiwgY2N3LCBWSVJUSU9fQ0NXX0RPSU5HX1NFVF9DT05GX0lO
RCk7Cj4gICAJaWYgKHJldCkKPiBAQCAtMTA5MiwxNyArMTEwMiwxNyBAQCBzdGF0aWMgdm9pZCB2
aXJ0aW9fY2N3X2ludF9oYW5kbGVyKHN0cnVjdCBjY3dfZGV2aWNlICpjZGV2LAo+ICAgCQkJdmNk
ZXYtPmVyciA9IC1FSU87Cj4gICAJfQo+ICAgCXZpcnRpb19jY3dfY2hlY2tfYWN0aXZpdHkodmNk
ZXYsIGFjdGl2aXR5KTsKPiAtCWZvcl9lYWNoX3NldF9iaXQoaSwgJnZjZGV2LT5pbmRpY2F0b3Jz
LAo+IC0JCQkgc2l6ZW9mKHZjZGV2LT5pbmRpY2F0b3JzKSAqIEJJVFNfUEVSX0JZVEUpIHsKPiAr
CWZvcl9lYWNoX3NldF9iaXQoaSwgaW5kaWNhdG9ycyh2Y2RldiksCj4gKwkJCSBzaXplb2YoKmlu
ZGljYXRvcnModmNkZXYpKSAqIEJJVFNfUEVSX0JZVEUpIHsKPiAgIAkJLyogVGhlIGJpdCBjbGVh
ciBtdXN0IGhhcHBlbiBiZWZvcmUgdGhlIHZyaW5nIGtpY2suICovCj4gLQkJY2xlYXJfYml0KGks
ICZ2Y2Rldi0+aW5kaWNhdG9ycyk7Cj4gKwkJY2xlYXJfYml0KGksIGluZGljYXRvcnModmNkZXYp
KTsKPiAgIAkJYmFycmllcigpOwo+ICAgCQl2cSA9IHZpcnRpb19jY3dfdnFfYnlfaW5kKHZjZGV2
LCBpKTsKPiAgIAkJdnJpbmdfaW50ZXJydXB0KDAsIHZxKTsKPiAgIAl9Cj4gLQlpZiAodGVzdF9i
aXQoMCwgJnZjZGV2LT5pbmRpY2F0b3JzMikpIHsKPiArCWlmICh0ZXN0X2JpdCgwLCBpbmRpY2F0
b3JzMih2Y2RldikpKSB7Cj4gICAJCXZpcnRpb19jb25maWdfY2hhbmdlZCgmdmNkZXYtPnZkZXYp
Owo+IC0JCWNsZWFyX2JpdCgwLCAmdmNkZXYtPmluZGljYXRvcnMyKTsKPiArCQljbGVhcl9iaXQo
MCwgaW5kaWNhdG9yczIodmNkZXYpKTsKPiAgIAl9Cj4gICB9Cj4gICAKPiAKCkhlcmUgYWdhaW4g
anVzdCBhIGZhc3QgY2hlY2suCkkgd2lsbCBnbyBpbiB0aGUgZnVuY3Rpb25hbCBsYXRlci4KClJl
Z2FyZHMsClBpZXJyZQoKCi0tIApQaWVycmUgTW9yZWwKTGludXgvS1ZNL1FFTVUgaW4gQsO2Ymxp
bmdlbiAtIEdlcm1hbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5s
aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp
bG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==