From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
levinsasha928@gmail.com, Amit Shah <amit.shah@redhat.com>
Subject: [PATCH v5 08/11] virtio: net: Move vq and vq buf removal into separate function
Date: Thu, 15 Dec 2011 18:15:54 +0530 [thread overview]
Message-ID: <7b3b395af6da6b459245ca67755932f1dd2d6496.1323952934.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1323952933.git.amit.shah@redhat.com>
In-Reply-To: <cover.1323952933.git.amit.shah@redhat.com>
The remove and PM freeze functions will share this code.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/net/virtio_net.c | 19 ++++++++++++-------
1 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 6baa563..697a0fc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1123,24 +1123,29 @@ static void free_unused_bufs(struct virtnet_info *vi)
BUG_ON(vi->num != 0);
}
-static void __devexit virtnet_remove(struct virtio_device *vdev)
+static void remove_vq_common(struct virtnet_info *vi)
{
- struct virtnet_info *vi = vdev->priv;
-
/* Stop all the virtqueues. */
- vdev->config->reset(vdev);
-
+ vi->vdev->config->reset(vi->vdev);
- unregister_netdev(vi->dev);
cancel_delayed_work_sync(&vi->refill);
/* Free unused buffers in both send and recv, if any. */
free_unused_bufs(vi);
- vdev->config->del_vqs(vi->vdev);
+ vi->vdev->config->del_vqs(vi->vdev);
while (vi->pages)
__free_pages(get_a_page(vi, GFP_KERNEL), 0);
+}
+
+static void __devexit virtnet_remove(struct virtio_device *vdev)
+{
+ struct virtnet_info *vi = vdev->priv;
+
+ unregister_netdev(vi->dev);
+
+ remove_vq_common(vi);
free_percpu(vi->stats);
free_netdev(vi->dev);
--
1.7.7.3
next prev parent reply other threads:[~2011-12-15 12:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 12:45 [PATCH v5 00/11] virtio: s4 support Amit Shah
2011-12-15 12:45 ` [PATCH v5 01/11] virtio: pci: switch to new PM API Amit Shah
2011-12-15 12:45 ` [PATCH v5 02/11] virtio: pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-12-15 12:45 ` [PATCH v5 03/11] virtio: console: Move vq and vq buf removal into separate functions Amit Shah
2011-12-15 12:45 ` [PATCH v5 04/11] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-12-15 12:45 ` [PATCH v5 05/11] virtio: blk: Move vq initialization to separate function Amit Shah
2011-12-15 12:45 ` [PATCH v5 06/11] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-12-15 12:45 ` [PATCH v5 07/11] virtio: net: Move vq initialization into separate function Amit Shah
2011-12-15 12:45 ` Amit Shah [this message]
2011-12-15 12:45 ` [PATCH v5 09/11] virtio: net: Add freeze, restore handlers to support S4 Amit Shah
2011-12-15 12:45 ` [PATCH v5 10/11] virtio: balloon: Move vq initialization into separate function Amit Shah
2011-12-15 12:45 ` [PATCH v5 11/11] virtio: balloon: Add freeze, restore handlers to support S4 Amit Shah
2011-12-15 13:13 ` [PATCH v5 00/11] virtio: s4 support Michael S. Tsirkin
2011-12-15 14:55 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3b395af6da6b459245ca67755932f1dd2d6496.1323952934.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).