Linux virtualization list
 help / color / mirror / Atom feed
From: Roman Gushchin <roman@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Baoquan He <baoquan.he@linux.dev>,
	 sashiko-reviews@lists.linux.dev,
	Zack Rusin <zack.rusin@broadcom.com>,
	 Petr Mladek <pmladek@suse.com>, Mike Rapoport <rppt@kernel.org>,
	 Pasha Tatashin <pasha.tatashin@soleen.com>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Dave Young <ruirui.yang@linux.dev>,
	 Borislav Petkov <bp@alien8.de>,
	 Ajay Kaher <ajay.kaher@broadcom.com>,
	 Alexey Makhalov <alexey.makhalov@broadcom.com>,
	 x86@kernel.org,  Joel Granados <joel.granados@kernel.org>,
	 Thomas Gleixner <tglx@kernel.org>,
	 Ingo Molnar <mingo@redhat.com>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	 virtualization@lists.linux.dev,
	bcm-kernel-feedback-list@broadcom.com,
	 John Ogness <john.ogness@linutronix.de>,
	 Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	 Kees Cook <kees@kernel.org>,  Jonathan Corbet <corbet@lwn.net>,
	 Bo Gan <bo.gan@broadcom.com>,
	 Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>,
	 kexec@lists.infradead.org,
	 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	 Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	 Stephen Brennan <stephen.s.brennan@oracle.com>,
	 Michael Kelley <mhklinux@outlook.com>,
	Ian Forbes <ian.forbes@broadcom.com>,
	 Bradley Morgan <brads@mainlining.org>,
	 "Michael S. Tsirkin" <mst@redhat.com>,
	 Eugenio Perez <eperezma@redhat.com>,
	 sashiko@lists.linux.dev
Subject: Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl
Date: Thu, 19 Nov 2026 15:35:18 +0000	[thread overview]
Message-ID: <7ia41p8gx2a1.fsf@castle.c.googlers.com> (raw)
In-Reply-To: <20261117230201.921ec5bddf49cd459ddb8428@linux-foundation.org> (Andrew Morton's message of "Tue, 17 Nov 2026 23:02:01 -0800")

Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He <baoquan.he@linux.dev> wrote:
>
>> On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote:
>> > > Allow administrators to disable host log transfer on ordinary guests or
>> > > opt in on encrypted guests. Expose the boolean recording policy through
>> > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested.
>> > > Zero disables recording, nonzero integers enable it, and reads return
>> > > 0 or 1.
>> > > 
>> > > Register the sysctl only after the logger is ready. A registration failure
>> > > leaves the internal default in force. Document that the log is sent
>> > > before kdump, and that disable_panic_notifiers_platform_list also skips
>> > > it.
>> > > 
>> > > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj
>> > > Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
>> > 
>> > Sashiko has reviewed this patch and found no issues.
>> 
>> It might be better to turn off this message if not issues found, just
>> like what LKP bot has been doing.
>
> (+sashiko@lists.linux.dev)
>
> Yes please.
>
> These emails do have a little bit of value: they tell you that Sashiko
> was able to apply the patch and to review it.  I guess.  Or something.

They are opt-in and some maintainers asked for them, so Idk if globally
disabling them is a good idea. Johannes suggested to send one email per
patchset, which I like as an idea, will implement a bit later.

I like the idea (from the thread) to send an email if a patch(set)
hasn't been reviewed, e.g. not applied correctly. Will implement as
opt-in feature too.

Thanks

  parent reply	other threads:[~2026-11-19 15:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:01 [PATCH v4 0/4] panic, x86/vmware: Preserve crash logs before kdump Zack Rusin
2026-11-18  6:01 ` [PATCH v4 1/4] panic: Add a platform panic notifier list Zack Rusin
2026-11-18  6:16   ` sashiko-bot
2026-11-20  8:36   ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 2/4] x86/vmware: Add a bounded panic log sender Zack Rusin
2026-11-18  6:18   ` sashiko-bot
2026-11-20  9:10   ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Zack Rusin
2026-11-18  6:14   ` sashiko-bot
2026-11-18  6:42     ` Baoquan He
2026-11-18  7:02       ` Andrew Morton
2026-11-18  7:51         ` Baoquan He
2026-11-18  7:53           ` Bradley Morgan
2026-11-18  8:09             ` Baoquan He
2026-11-19 11:07           ` Pratyush Yadav
2026-11-19 15:35         ` Roman Gushchin [this message]
2026-11-18 14:36       ` Steven Rostedt
2026-11-20  9:19   ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers Zack Rusin
2026-11-18  6:12   ` sashiko-bot
2026-11-20 10:27   ` Petr Mladek
2026-11-20 16:50     ` Zack Rusin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ia41p8gx2a1.fsf@castle.c.googlers.com \
    --to=roman@kernel.org \
    --cc=ajay.kaher@broadcom.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.makhalov@broadcom.com \
    --cc=baoquan.he@linux.dev \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bo.gan@broadcom.com \
    --cc=bp@alien8.de \
    --cc=brads@mainlining.org \
    --cc=brennan.lamoreaux@broadcom.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eperezma@redhat.com \
    --cc=gpiccoli@igalia.com \
    --cc=hpa@zytor.com \
    --cc=ian.forbes@broadcom.com \
    --cc=joel.granados@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=kees@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=maaz.mombasawala@broadcom.com \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=pmladek@suse.com \
    --cc=pratyush@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sashiko@lists.linux.dev \
    --cc=senozhatsky@chromium.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=tglx@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=x86@kernel.org \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox