From: Juergen Gross via Virtualization <virtualization@lists.linux-foundation.org>
To: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>,
linux-kernel@vger.kernel.org, x86@kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Wanpeng Li <wanpengli@tencent.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Alexey Makhalov <amakhalov@vmware.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/paravirt: use common macro for creating simple asm paravirt functions
Date: Wed, 9 Nov 2022 08:21:53 +0100 [thread overview]
Message-ID: <820ab144-5841-e3d9-88ec-52093f42be74@suse.com> (raw)
In-Reply-To: <7f620a41-c68d-20ad-cdde-cd545c772014@csail.mit.edu>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 890 bytes --]
On 09.11.22 06:16, Srivatsa S. Bhat wrote:
> Hi Juergen,
>
> Sorry for the delay in reviewing this patch!
>
> On 10/20/22 2:19 AM, Juergen Gross wrote:
>> There are some paravirt assembler functions which are sharing a common
>> pattern. Introduce a macro DEFINE_PARAVIRT_ASM() for creating them.
>>
>> The explicit _paravirt_nop() prototype in paravirt.c isn't needed, as
>> it is included in paravirt_types.h already.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> I just wanted to make a note that the part of this patch that's not
> purely cleanup is the addition of the alignment (__ALIGN_STR) to
> __raw_callee_save___kvm_vcpu_is_preempted(), _paravirt_nop() and
> paravirt_ret0(). Maybe that's worth calling out in the commit message?
I can do that.
>
> Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
Thanks,
Juergen
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2022-11-09 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 9:19 [PATCH] x86/paravirt: use common macro for creating simple asm paravirt functions Juergen Gross via Virtualization
2022-11-07 11:27 ` Juergen Gross via Virtualization
2022-11-09 5:16 ` Srivatsa S. Bhat
2022-11-09 7:21 ` Juergen Gross via Virtualization [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820ab144-5841-e3d9-88ec-52093f42be74@suse.com \
--to=virtualization@lists.linux-foundation.org \
--cc=amakhalov@vmware.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox