From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next 06/11] tuntap: split out XDP logic Date: Fri, 7 Sep 2018 11:29:34 +0800 Message-ID: <84ae17c1-f34b-610d-a5a1-ba8dce1732f3@redhat.com> References: <20180906040526.22518-1-jasowang@redhat.com> <20180906040526.22518-7-jasowang@redhat.com> <20180906131703-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180906131703-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE45bm0MDnmnIgwN+aXpSAwMToyMSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ IE9uIFRodSwgU2VwIDA2LCAyMDE4IGF0IDEyOjA1OjIxUE0gKzA4MDAsIEphc29uIFdhbmcgd3Jv dGU6Cj4+IFRoaXMgcGF0Y2ggc3BsaXQgb3V0IFhEUCBsb2dpYyBpbnRvIGEgc2luZ2xlIGZ1bmN0 aW9uLiBUaGlzIG1ha2UgaXQgdG8KPj4gYmUgcmV1c2VkIGJ5IFhEUCBiYXRjaGluZyBwYXRoIGlu IHRoZSBmb2xsb3dpbmcgcGF0Y2guCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGph c293YW5nQHJlZGhhdC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvbmV0L3R1bi5jIHwgODQgKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUg Y2hhbmdlZCwgNTEgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL25ldC90dW4uYyBiL2RyaXZlcnMvbmV0L3R1bi5jCj4+IGluZGV4IDM4OWFh MDcyN2NjNi4uMjFiMTI1MDIwYjNiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL25ldC90dW4uYwo+ PiArKysgYi9kcml2ZXJzL25ldC90dW4uYwo+PiBAQCAtMTYzNSw2ICsxNjM1LDQ0IEBAIHN0YXRp YyBib29sIHR1bl9jYW5fYnVpbGRfc2tiKHN0cnVjdCB0dW5fc3RydWN0ICp0dW4sIHN0cnVjdCB0 dW5fZmlsZSAqdGZpbGUsCj4+ICAgCXJldHVybiB0cnVlOwo+PiAgIH0KPj4gICAKPj4gK3N0YXRp YyB1MzIgdHVuX2RvX3hkcChzdHJ1Y3QgdHVuX3N0cnVjdCAqdHVuLAo+PiArCQkgICAgICBzdHJ1 Y3QgdHVuX2ZpbGUgKnRmaWxlLAo+PiArCQkgICAgICBzdHJ1Y3QgYnBmX3Byb2cgKnhkcF9wcm9n LAo+PiArCQkgICAgICBzdHJ1Y3QgeGRwX2J1ZmYgKnhkcCwKPj4gKwkJICAgICAgaW50ICplcnIp Cj4+ICt7Cj4+ICsJdTMyIGFjdCA9IGJwZl9wcm9nX3J1bl94ZHAoeGRwX3Byb2csIHhkcCk7Cj4+ ICsKPj4gKwlzd2l0Y2ggKGFjdCkgewo+PiArCWNhc2UgWERQX1JFRElSRUNUOgo+PiArCQkqZXJy ID0geGRwX2RvX3JlZGlyZWN0KHR1bi0+ZGV2LCB4ZHAsIHhkcF9wcm9nKTsKPj4gKwkJeGRwX2Rv X2ZsdXNoX21hcCgpOwo+PiArCQlpZiAoKmVycikKPj4gKwkJCWJyZWFrOwo+PiArCQlnb3RvIG91 dDsKPj4gKwljYXNlIFhEUF9UWDoKPj4gKwkJKmVyciA9IHR1bl94ZHBfdHgodHVuLT5kZXYsIHhk cCk7Cj4+ICsJCWlmICgqZXJyIDwgMCkKPj4gKwkJCWJyZWFrOwo+PiArCQkqZXJyID0gMDsKPj4g KwkJZ290byBvdXQ7Cj4+ICsJY2FzZSBYRFBfUEFTUzoKPj4gKwkJZ290byBvdXQ7Cj4gRG8gd2Ug bmVlZCBnb3RvPyB3aHkgbm90IGp1c3QgcmV0dXJuPwoKSSBkb24ndCBzZWUgYW55IGRpZmZlcmVu Y2UuCgo+Cj4+ICsJZGVmYXVsdDoKPj4gKwkJYnBmX3dhcm5faW52YWxpZF94ZHBfYWN0aW9uKGFj dCk7Cj4+ICsJCS8qIGZhbGwgdGhyb3VnaCAqLwo+PiArCWNhc2UgWERQX0FCT1JURUQ6Cj4+ICsJ CXRyYWNlX3hkcF9leGNlcHRpb24odHVuLT5kZXYsIHhkcF9wcm9nLCBhY3QpOwo+PiArCQkvKiBm YWxsIHRocm91Z2ggKi8KPj4gKwljYXNlIFhEUF9EUk9QOgo+PiArCQlicmVhazsKPj4gKwl9Cj4+ ICsKPj4gKwlwdXRfcGFnZSh2aXJ0X3RvX2hlYWRfcGFnZSh4ZHAtPmRhdGFfaGFyZF9zdGFydCkp Owo+IHB1dCBoZXJlIGJlY2F1c2UgY2FsbGVyIGRvZXMgZ2V0X3BhZ2UgOiggTm90IHByZXR0eS4K PiBJJ2QgbW92ZSB0aGlzIG91dCB0byB0aGUgY2FsbGVyLgoKVGhlbiB3ZSBuZWVkIGEgc3dpdGNo IGluIHRoZSBjYWxsZXIsIG5vdCBzdXJlIGl0J3MgYmV0dGVyLgoKPgo+PiArb3V0Ogo+PiArCXJl dHVybiBhY3Q7Cj4gSG93IGFib3V0IGNvbWJpbmluZyBlcnIgYW5kIGFjdD8gZXJyIGlzIDwgMCBY RFBfUEFTUyBpcyA+IDAuCj4gTm8gbmVlZCBmb3IgcG9pbnRlcnMgdGhlbi4KCk9rLgoKPgo+PiAr fQo+PiArCj4+ICAgc3RhdGljIHN0cnVjdCBza19idWZmICp0dW5fYnVpbGRfc2tiKHN0cnVjdCB0 dW5fc3RydWN0ICp0dW4sCj4+ICAgCQkJCSAgICAgc3RydWN0IHR1bl9maWxlICp0ZmlsZSwKPj4g ICAJCQkJICAgICBzdHJ1Y3QgaW92X2l0ZXIgKmZyb20sCj4+IEBAIC0xNjQ1LDEwICsxNjgzLDEw IEBAIHN0YXRpYyBzdHJ1Y3Qgc2tfYnVmZiAqdHVuX2J1aWxkX3NrYihzdHJ1Y3QgdHVuX3N0cnVj dCAqdHVuLAo+PiAgIAlzdHJ1Y3Qgc2tfYnVmZiAqc2tiID0gTlVMTDsKPj4gICAJc3RydWN0IGJw Zl9wcm9nICp4ZHBfcHJvZzsKPj4gICAJaW50IGJ1ZmxlbiA9IFNLQl9EQVRBX0FMSUdOKHNpemVv ZihzdHJ1Y3Qgc2tiX3NoYXJlZF9pbmZvKSk7Cj4+IC0JdW5zaWduZWQgaW50IGRlbHRhID0gMDsK Pj4gICAJY2hhciAqYnVmOwo+PiAgIAlzaXplX3QgY29waWVkOwo+PiAtCWludCBlcnIsIHBhZCA9 IFRVTl9SWF9QQUQ7Cj4+ICsJaW50IHBhZCA9IFRVTl9SWF9QQUQ7Cj4+ICsJaW50IGVyciA9IDA7 Cj4+ICAgCj4+ICAgCXJjdV9yZWFkX2xvY2soKTsKPj4gICAJeGRwX3Byb2cgPSByY3VfZGVyZWZl cmVuY2UodHVuLT54ZHBfcHJvZyk7Cj4+IEBAIC0xNjg1LDkgKzE3MjMsOCBAQCBzdGF0aWMgc3Ry dWN0IHNrX2J1ZmYgKnR1bl9idWlsZF9za2Ioc3RydWN0IHR1bl9zdHJ1Y3QgKnR1biwKPj4gICAJ bG9jYWxfYmhfZGlzYWJsZSgpOwo+PiAgIAlyY3VfcmVhZF9sb2NrKCk7Cj4+ICAgCXhkcF9wcm9n ID0gcmN1X2RlcmVmZXJlbmNlKHR1bi0+eGRwX3Byb2cpOwo+PiAtCWlmICh4ZHBfcHJvZyAmJiAh KnNrYl94ZHApIHsKPj4gKwlpZiAoeGRwX3Byb2cpIHsKPj4gICAJCXN0cnVjdCB4ZHBfYnVmZiB4 ZHA7Cj4+IC0JCXZvaWQgKm9yaWdfZGF0YTsKPj4gICAJCXUzMiBhY3Q7Cj4+ICAgCj4+ICAgCQl4 ZHAuZGF0YV9oYXJkX3N0YXJ0ID0gYnVmOwo+PiBAQCAtMTY5NSwzMyArMTczMiwxNCBAQCBzdGF0 aWMgc3RydWN0IHNrX2J1ZmYgKnR1bl9idWlsZF9za2Ioc3RydWN0IHR1bl9zdHJ1Y3QgKnR1biwK Pj4gICAJCXhkcF9zZXRfZGF0YV9tZXRhX2ludmFsaWQoJnhkcCk7Cj4+ICAgCQl4ZHAuZGF0YV9l bmQgPSB4ZHAuZGF0YSArIGxlbjsKPj4gICAJCXhkcC5yeHEgPSAmdGZpbGUtPnhkcF9yeHE7Cj4+ IC0JCW9yaWdfZGF0YSA9IHhkcC5kYXRhOwo+PiAtCQlhY3QgPSBicGZfcHJvZ19ydW5feGRwKHhk cF9wcm9nLCAmeGRwKTsKPj4gLQo+PiAtCQlzd2l0Y2ggKGFjdCkgewo+PiAtCQljYXNlIFhEUF9S RURJUkVDVDoKPj4gLQkJCWVyciA9IHhkcF9kb19yZWRpcmVjdCh0dW4tPmRldiwgJnhkcCwgeGRw X3Byb2cpOwo+PiAtCQkJeGRwX2RvX2ZsdXNoX21hcCgpOwo+PiAtCQkJaWYgKGVycikKPj4gLQkJ CQlnb3RvIGVycl94ZHA7Cj4+IC0JCQlnb3RvIG91dDsKPj4gLQkJY2FzZSBYRFBfVFg6Cj4+IC0J CQlpZiAodHVuX3hkcF90eCh0dW4tPmRldiwgJnhkcCkgPCAwKQo+PiAtCQkJCWdvdG8gZXJyX3hk cDsKPj4gLQkJCWdvdG8gb3V0Owo+PiAtCQljYXNlIFhEUF9QQVNTOgo+PiAtCQkJZGVsdGEgPSBv cmlnX2RhdGEgLSB4ZHAuZGF0YTsKPj4gLQkJCWxlbiA9IHhkcC5kYXRhX2VuZCAtIHhkcC5kYXRh Owo+PiAtCQkJYnJlYWs7Cj4+IC0JCWRlZmF1bHQ6Cj4+IC0JCQlicGZfd2Fybl9pbnZhbGlkX3hk cF9hY3Rpb24oYWN0KTsKPj4gLQkJCS8qIGZhbGwgdGhyb3VnaCAqLwo+PiAtCQljYXNlIFhEUF9B Qk9SVEVEOgo+PiAtCQkJdHJhY2VfeGRwX2V4Y2VwdGlvbih0dW4tPmRldiwgeGRwX3Byb2csIGFj dCk7Cj4+IC0JCQkvKiBmYWxsIHRocm91Z2ggKi8KPj4gLQkJY2FzZSBYRFBfRFJPUDoKPj4gKwkJ YWN0ID0gdHVuX2RvX3hkcCh0dW4sIHRmaWxlLCB4ZHBfcHJvZywgJnhkcCwgJmVycik7Cj4+ICsJ CWlmIChlcnIpCj4+ICAgCQkJZ290byBlcnJfeGRwOwo+PiAtCQl9Cj4+ICsJCWlmIChhY3QgIT0g WERQX1BBU1MpCj4+ICsJCQlnb3RvIG91dDsKPiBsaWtlbHk/CgpJdCBkZXBlbmRzIG9uIHRoZSBY RFAgcHJvZ3JhbSwgc28gSSB0ZW5kIG5vdCB0byB1c2UgaXQuCgo+Cj4+ICsKPj4gKwkJcGFkID0g eGRwLmRhdGEgLSB4ZHAuZGF0YV9oYXJkX3N0YXJ0Owo+PiArCQlsZW4gPSB4ZHAuZGF0YV9lbmQg LSB4ZHAuZGF0YTsKPj4gICAJfQo+PiAgIAlyY3VfcmVhZF91bmxvY2soKTsKPj4gICAJbG9jYWxf YmhfZW5hYmxlKCk7Cj4+IEBAIC0xNzI5LDE4ICsxNzQ3LDE4IEBAIHN0YXRpYyBzdHJ1Y3Qgc2tf YnVmZiAqdHVuX2J1aWxkX3NrYihzdHJ1Y3QgdHVuX3N0cnVjdCAqdHVuLAo+PiAgIGJ1aWxkOgo+ PiAgIAlza2IgPSBidWlsZF9za2IoYnVmLCBidWZsZW4pOwo+PiAgIAlpZiAoIXNrYikgewo+PiAr CQlwdXRfcGFnZShhbGxvY19mcmFnLT5wYWdlKTsKPj4gICAJCXNrYiA9IEVSUl9QVFIoLUVOT01F TSk7Cj4+ICAgCQlnb3RvIG91dDsKPj4gICAJfQo+PiAgIAo+PiAtCXNrYl9yZXNlcnZlKHNrYiwg cGFkIC0gZGVsdGEpOwo+PiArCXNrYl9yZXNlcnZlKHNrYiwgcGFkKTsKPj4gICAJc2tiX3B1dChz a2IsIGxlbik7Cj4+ICAgCj4+ICAgCXJldHVybiBza2I7Cj4+ICAgCj4+ICAgZXJyX3hkcDoKPj4g LQlhbGxvY19mcmFnLT5vZmZzZXQgLT0gYnVmbGVuOwo+PiAtCXB1dF9wYWdlKGFsbG9jX2ZyYWct PnBhZ2UpOwo+PiArCXRoaXNfY3B1X2luYyh0dW4tPnBjcHVfc3RhdHMtPnJ4X2Ryb3BwZWQpOwo+ Cj4gVGhpcyBmaXhlcyBidWcgaW4gcHJldmlvdXMgcGF0Y2ggd2hpY2ggZHJvcHBlZCBpdC4gT0sg OikKClllcywgYnV0IGxldCBtZSBtb3ZlIHRoaXMgdG8gdGhlIGJ1Z2d5IHBhdGNoLgoKVGhhbmtz Cgo+PiAgIG91dDoKPj4gICAJcmN1X3JlYWRfdW5sb2NrKCk7Cj4+ICAgCWxvY2FsX2JoX2VuYWJs ZSgpOwo+PiAtLSAKPj4gMi4xNy4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25A bGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24u b3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=