From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED372DF65 for ; Wed, 6 Dec 2023 11:47:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BA7CE61471 for ; Wed, 6 Dec 2023 11:47:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BA7CE61471 X-Virus-Scanned: amavisd-new at osuosl.org X-Spam-Flag: NO X-Spam-Score: -4.198 X-Spam-Level: Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ymfnzGv6zBmr for ; Wed, 6 Dec 2023 11:47:51 +0000 (UTC) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by smtp3.osuosl.org (Postfix) with ESMTPS id D2C4360B1C for ; Wed, 6 Dec 2023 11:47:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D2C4360B1C Received: from kwepemi100024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SlbCK2HfszrV0l; Wed, 6 Dec 2023 19:43:57 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemi100024.china.huawei.com (7.221.188.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 19:47:44 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.035; Wed, 6 Dec 2023 19:47:44 +0800 From: "Gonglei (Arei)" To: Herbert Xu CC: "linux-crypto@vger.kernel.org" , "pasic@linux.ibm.com" , "mst@redhat.com" , "jasowang@redhat.com" , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , wangyangxin Subject: RE: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet Thread-Topic: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet Thread-Index: Adobp2Ma20NfNCVRS52WT53esc9NTAIVDLQAAQ+I38A= Date: Wed, 6 Dec 2023 11:47:44 +0000 Message-ID: <860e8f2285ae4350af3a14a5367c462a@huawei.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CFilter-Loop: Reflected Hi Herbert, > -----Original Message----- > From: Herbert Xu [mailto:herbert@gondor.apana.org.au] > Sent: Friday, December 1, 2023 6:11 PM > To: Gonglei (Arei) > Cc: linux-crypto@vger.kernel.org; pasic@linux.ibm.com; mst@redhat.com; > jasowang@redhat.com; virtualization@lists.linux-foundation.org; > linux-kernel@vger.kernel.org; wangyangxin ; > Gonglei (Arei) > Subject: Re: [PATCH] crypto: virtio-crypto: Handle dataq logic with taskl= et >=20 > Gonglei Arei wrote: > > Doing ipsec produces a spinlock recursion warning. > > This is due to crypto_finalize_request() being called in the upper half= . > > Move virtual data queue processing of virtio-crypto driver to tasklet. > > > > Fixes: dbaf0624ffa57 ("crypto: add virtio-crypto driver") > > Reported-by: Halil Pasic > > Signed-off-by: wangyangxin > > Signed-off-by: Gonglei > > --- > > drivers/crypto/virtio/virtio_crypto_common.h | 2 ++ > > drivers/crypto/virtio/virtio_crypto_core.c | 23 +++++++++++++--------= -- > > 2 files changed, 15 insertions(+), 10 deletions(-) >=20 > Patch applied. Thanks. Sorry, pls apply version 2 if possible. Regards, -Gonglei > -- > Email: Herbert Xu Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt