* [PATCH 1/2] virtio_blk: typo fix [not found] <1425192883-5930-1-git-send-email-mst@redhat.com> @ 2015-03-01 7:39 ` Michael S. Tsirkin 2015-03-01 7:39 ` [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 Michael S. Tsirkin 1 sibling, 0 replies; 4+ messages in thread From: Michael S. Tsirkin @ 2015-03-01 7:39 UTC (permalink / raw) To: linux-kernel, Rusty Russell, virtualization, qemu-devel Now that QEmu reuses linux virtio headers, we noticed a typo in the exported virtio block header. Fix it up. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/uapi/linux/virtio_blk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h index 3c53eec..b695ba9 100644 --- a/include/uapi/linux/virtio_blk.h +++ b/include/uapi/linux/virtio_blk.h @@ -60,7 +60,7 @@ struct virtio_blk_config { __u32 size_max; /* The maximum number of segments (if VIRTIO_BLK_F_SEG_MAX) */ __u32 seg_max; - /* geometry the device (if VIRTIO_BLK_F_GEOMETRY) */ + /* geometry of the device (if VIRTIO_BLK_F_GEOMETRY) */ struct virtio_blk_geometry { __u16 cylinders; __u8 heads; -- MST ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 [not found] <1425192883-5930-1-git-send-email-mst@redhat.com> 2015-03-01 7:39 ` [PATCH 1/2] virtio_blk: typo fix Michael S. Tsirkin @ 2015-03-01 7:39 ` Michael S. Tsirkin 2015-03-02 0:15 ` Rusty Russell 1 sibling, 1 reply; 4+ messages in thread From: Michael S. Tsirkin @ 2015-03-01 7:39 UTC (permalink / raw) To: linux-kernel, Rusty Russell, virtualization, qemu-devel Fix up comment to match virtio 1.0 logic: virtio_blk_outhdr isn't the first elements anymore, the only requirement is that it comes first in the s/g list. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/uapi/linux/virtio_blk.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h index b695ba9..19c66fc 100644 --- a/include/uapi/linux/virtio_blk.h +++ b/include/uapi/linux/virtio_blk.h @@ -119,7 +119,11 @@ struct virtio_blk_config { #define VIRTIO_BLK_T_BARRIER 0x80000000 #endif /* !VIRTIO_BLK_NO_LEGACY */ -/* This is the first element of the read scatter-gather list. */ +/* + * This comes first in the read scatter-gather list. + * For legacy virtio, if VIRTIO_F_ANY_LAYOUT is not negotiated, + * this is the first element of the read scatter-gather list. + */ struct virtio_blk_outhdr { /* VIRTIO_BLK_T* */ __virtio32 type; -- MST ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 2015-03-01 7:39 ` [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 Michael S. Tsirkin @ 2015-03-02 0:15 ` Rusty Russell 2015-03-05 8:40 ` Michael S. Tsirkin 0 siblings, 1 reply; 4+ messages in thread From: Rusty Russell @ 2015-03-02 0:15 UTC (permalink / raw) To: Michael S. Tsirkin, linux-kernel, virtualization, qemu-devel "Michael S. Tsirkin" <mst@redhat.com> writes: > Fix up comment to match virtio 1.0 logic: > virtio_blk_outhdr isn't the first elements anymore, > the only requirement is that it comes first in > the s/g list. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Thanks, both applied. Cheers, Rusty. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 2015-03-02 0:15 ` Rusty Russell @ 2015-03-05 8:40 ` Michael S. Tsirkin 0 siblings, 0 replies; 4+ messages in thread From: Michael S. Tsirkin @ 2015-03-05 8:40 UTC (permalink / raw) To: Rusty Russell; +Cc: qemu-devel, linux-kernel, virtualization On Mon, Mar 02, 2015 at 10:45:37AM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" <mst@redhat.com> writes: > > Fix up comment to match virtio 1.0 logic: > > virtio_blk_outhdr isn't the first elements anymore, > > the only requirement is that it comes first in > > the s/g list. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > Thanks, both applied. > > Cheers, > Rusty. Hmm, I don't see them in your virtio-next tree. Did I miss something? I know these are just headers but it's in UAPI so I'd like to make them correct ASAP. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1425192883-5930-1-git-send-email-mst@redhat.com>
2015-03-01 7:39 ` [PATCH 1/2] virtio_blk: typo fix Michael S. Tsirkin
2015-03-01 7:39 ` [PATCH 2/2] virtio_blk: fix comment for virtio 1.0 Michael S. Tsirkin
2015-03-02 0:15 ` Rusty Russell
2015-03-05 8:40 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).