From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH RFC] virtio_net: fix refill related races
Date: Thu, 08 Dec 2011 15:07:29 +1030 [thread overview]
Message-ID: <8739cvisqe.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111207152120.GA23417@redhat.com>
On Wed, 7 Dec 2011 17:21:22 +0200, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> Fix theoretical races related to refill work:
> 1. After napi is disabled by ndo_stop, refill work
> can run and re-enable it.
> 2. Refill can reschedule itself, if this happens
> it can run after cancel_delayed_work_sync,
> and will access device after it is destroyed.
>
> As a solution, add flags to track napi state and
> to disable refill, and toggle them on start, stop
> and remove; check these flags on refill.
Why isn't a "dont-readd" flag sufficient?
Cheers,
Rusty.
next prev parent reply other threads:[~2011-12-08 4:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 15:21 [PATCH RFC] virtio_net: fix refill related races Michael S. Tsirkin
2011-12-08 4:37 ` Rusty Russell [this message]
2011-12-11 14:44 ` Michael S. Tsirkin
2011-12-11 22:55 ` Rusty Russell
2011-12-12 11:54 ` Michael S. Tsirkin
2011-12-13 2:35 ` Rusty Russell
2011-12-14 23:54 ` Tejun Heo
2011-12-20 19:09 ` Michael S. Tsirkin
2011-12-20 19:09 ` Tejun Heo
2011-12-20 19:30 ` Michael S. Tsirkin
2011-12-20 19:31 ` Tejun Heo
2011-12-20 19:45 ` Michael S. Tsirkin
2011-12-20 23:43 ` Rusty Russell
2011-12-21 9:06 ` Michael S. Tsirkin
2011-12-22 3:53 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739cvisqe.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).