From: Takashi Iwai <tiwai@suse.de>
To: Aiswarya Cyriac <aiswarya.cyriac@opensynergy.com>
Cc: mst@redhat.com, jasowang@redhat.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org,
Anton Yakovlev <anton.yakovlev@opensynergy.com>,
coverity-bot <keescook+coverity-bot@chromium.org>
Subject: Re: [PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.
Date: Tue, 13 Feb 2024 10:02:24 +0100 [thread overview]
Message-ID: <875xyska8v.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240213085131.503569-1-aiswarya.cyriac@opensynergy.com>
On Tue, 13 Feb 2024 09:51:30 +0100,
Aiswarya Cyriac wrote:
>
> Fix the following warning when building virtio_snd driver.
>
> "
> *** CID 1583619: Uninitialized variables (UNINIT)
> sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op()
> 288
> 289 break;
> 290 }
> 291
> 292 kfree(tlv);
> 293
> vvv CID 1583619: Uninitialized variables (UNINIT)
> vvv Using uninitialized value "rc".
> 294 return rc;
> 295 }
> 296
> 297 /**
> 298 * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type.
> 299 * @snd: VirtIO sound device.
> "
>
> Signed-off-by: Anton Yakovlev <anton.yakovlev@opensynergy.com>
> Signed-off-by: Aiswarya Cyriac <aiswarya.cyriac@opensynergy.com>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
> Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")
Thanks, applied.
Takashi
next prev parent reply other threads:[~2024-02-13 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:51 [PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning Aiswarya Cyriac
2024-02-13 9:02 ` Takashi Iwai [this message]
2024-02-13 9:07 ` Michael S. Tsirkin
2024-02-13 9:42 ` Takashi Iwai
2024-02-13 9:06 ` Michael S. Tsirkin
2024-02-14 9:08 ` Aiswarya Cyriac
2024-02-14 11:30 ` Michael S. Tsirkin
2024-02-14 11:37 ` Takashi Iwai
2024-02-14 13:07 ` Aiswarya Cyriac
2024-02-14 13:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xyska8v.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=aiswarya.cyriac@opensynergy.com \
--cc=alsa-devel@alsa-project.org \
--cc=anton.yakovlev@opensynergy.com \
--cc=jasowang@redhat.com \
--cc=keescook+coverity-bot@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).