virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Wei Liu <wei.liu@kernel.org>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	mikelley@microsoft.com, wei.liu@kernel.org,
	Nuno Das Neves <nunodasneves@linux.microsoft.com>,
	sunilmut@microsoft.com,
	virtualization@lists.linux-foundation.org,
	viremana@linux.microsoft.com, ligrassi@microsoft.com
Subject: Re: [RFC PATCH 04/18] virt/mshv: request version ioctl
Date: Wed, 07 Apr 2021 16:02:56 +0200	[thread overview]
Message-ID: <875z0ychv3.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20210407134302.ng6n4el2km7sujfp@liuwe-devbox-debian-v2>

Wei Liu <wei.liu@kernel.org> writes:

> On Wed, Apr 07, 2021 at 09:38:21AM +0200, Vitaly Kuznetsov wrote:
>
>> One more though: it is probably a good idea to introduce selftests for
>> /dev/mshv (similar to KVM's selftests in
>> /tools/testing/selftests/kvm). Selftests don't really need a stable ABI
>> as they live in the same linux.git and can be updated in the same patch
>> series which changes /dev/mshv behavior. Selftests are very useful for
>> checking there are no regressions, especially in the situation when
>> there's no publicly available userspace for /dev/mshv.
>
> I think this can wait until we merge the first implementation in tree.
> There are still a lot of moving parts. Our (currently limited) internal
> test cases need more cleaning up before they are ready. I certainly
> don't want to distract Nuno from getting the foundation right.
>

I'm absolutely fine with this approach, selftests are a nice add-on, not
a requirement for the initial implementation. Also, to make them more
useful to mere mortals, a doc on how to run Linux as root Hyper-V
partition would come handy)

-- 
Vitaly

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2021-04-07 14:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1605918637-12192-1-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:40 ` [RFC PATCH 00/18] Microsoft Hypervisor root partition ioctl interface Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-5-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:41   ` [RFC PATCH 04/18] virt/mshv: request version ioctl Michael Kelley via Virtualization
     [not found]   ` <87y2fxmlmb.fsf@vitty.brq.redhat.com>
     [not found]     ` <194e0dad-495e-ae94-3f51-d2c95da52139@linux.microsoft.com>
2021-03-05  9:18       ` Vitaly Kuznetsov
     [not found]         ` <fc88ba72-83ab-025e-682d-4981762ed4f6@linux.microsoft.com>
2021-04-07  7:38           ` Vitaly Kuznetsov
     [not found]             ` <20210407134302.ng6n4el2km7sujfp@liuwe-devbox-debian-v2>
2021-04-07 14:02               ` Vitaly Kuznetsov [this message]
     [not found] ` <1605918637-12192-7-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:42   ` [RFC PATCH 06/18] virt/mshv: create, initialize, finalize, delete partition hypercalls Michael Kelley via Virtualization
     [not found]     ` <e6cc796d-f9ee-5203-95a9-05906f95d3f8@linux.microsoft.com>
2021-03-04 23:58       ` Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-8-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:44   ` [RFC PATCH 07/18] virt/mshv: withdraw memory hypercall Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-9-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:45   ` [RFC PATCH 08/18] virt/mshv: map and unmap guest memory Michael Kelley via Virtualization
     [not found]     ` <d63330fa-de83-85de-c8ec-74cc90d680e3@linux.microsoft.com>
2021-03-08 19:30       ` Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-11-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:47   ` [RFC PATCH 10/18] virt/mshv: get and set vcpu registers ioctls Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-12-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:47   ` [RFC PATCH 11/18] virt/mshv: set up synic pages for intercept messages Michael Kelley via Virtualization
     [not found]     ` <9e06a119-880f-5199-903b-056675331d6f@linux.microsoft.com>
2021-03-11 20:45       ` Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-16-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:48   ` [RFC PATCH 15/18] virt/mshv: get and set vp state ioctls Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-17-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-08 19:49   ` [RFC PATCH 16/18] virt/mshv: mmap vp register page Michael Kelley via Virtualization
     [not found] ` <1605918637-12192-2-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-09 13:04   ` [RFC PATCH 01/18] x86/hyperv: convert hyperv statuses to linux error codes Vitaly Kuznetsov
     [not found] ` <1605918637-12192-6-git-send-email-nunodasneves@linux.microsoft.com>
2021-02-09 13:15   ` [RFC PATCH 05/18] virt/mshv: create partition ioctl Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z0ychv3.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=ligrassi@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=nunodasneves@linux.microsoft.com \
    --cc=sunilmut@microsoft.com \
    --cc=viremana@linux.microsoft.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).