From: Rusty Russell <rusty@rustcorp.com.au>
To: Laszlo Ersek <lersek@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: miscalculated vring size in virtio-0.9.5.pdf?
Date: Wed, 19 Sep 2012 15:12:43 +0930 [thread overview]
Message-ID: <87a9wmpnzg.fsf@rustcorp.com.au> (raw)
In-Reply-To: <5058EC85.5080402@redhat.com>
Laszlo Ersek <lersek@redhat.com> writes:
> Hi,
>
> the vring_size() formula in section 2.3 seems to miss
>
> (a) "vring_avail.used_event" in the first ALIGN(), and
>
> (b) "vring_used.flags", "vring_used.idx", "vring_used.avail_event" in
> the second ALIGN().
>
> vring_size() in Appendix A fixes (b) (no rounding up to page size
> though), but (a) is wrong there too, I believe.
Hi Laszlo,
The effect is the same, due to ALIGN(). However, the latest
copy of the spec on github should be consistent. Indeed, I cleaned up
the header in the Appendix so it actually compiles...
Cheers,
Rusty.
prev parent reply other threads:[~2012-09-19 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 21:49 miscalculated vring size in virtio-0.9.5.pdf? Laszlo Ersek
2012-09-19 5:42 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9wmpnzg.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=lersek@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).