From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3621C7005 for ; Tue, 12 Aug 2025 01:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754962216; cv=none; b=LvvlUN7BJh/oR4YziLBlkt2YUB80sLdrAOebo5l/95SWITJkdJGFlMi9spz/wVKjRpLW6sNodh5K/iT6VLYe9pYYf9XqL0xZsbs2bDqkxrjY46NxB3ntDTeEJPDrQ723ZDoe0gvj9y5Vm02Yrv/tt2tAU5wOzqsFFqlEFJ46ugs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754962216; c=relaxed/simple; bh=5VapdnES7ub01fEzwLbmifK+dKN+v5agxO17nHqVte8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SCDaSH2WL9qEQtT1aOt+3ZGMrBYhfShrdyQacXQnpvmcmdxQI4XtTCxXX0fhGJQ+NUXZMvniUY1ehBmocBBi8AHvonsoZkuPJclRcfY6Q8Q57xvkZrYX8ypFApu4IMN1W9rle+oASyo1VFO2SF/py3OnmqpHOlbC4tQ1IytI0Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=JMbfwpsR; arc=none smtp.client-ip=115.124.30.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="JMbfwpsR" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1754962210; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=djZxdkbYS5ABjJh5vZ+OSyzqxKEA12clHOn12k1eFBw=; b=JMbfwpsRNCi9vQ8K0CdPK0zFsmtjl1OT5ze7/nvcC9uy1+BBNgnJzrXzYo/jsMsVasDPYYjhUbEL4r0yaX89uL9z80p/b5ORZUZIyBKo2n7zC/7pwar7Es6i3EZ6u8anU7cbm5tcI49YJa+A9LIyWz09nPLOifv3+UzTQQDKM9s= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WlYvemQ_1754962181 cluster:ay36) by smtp.aliyun-inc.com; Tue, 12 Aug 2025 09:30:08 +0800 From: "Huang, Ying" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?Q?P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Chris Mason , Josef Bacik , David Sterba , Muchun Song , Oscar Salvador , Dave Kleikamp , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Alistair Popple , Minchan Kim , Sergey Senozhatsky Subject: Re: [PATCH v1 0/2] mm: remove MIGRATEPAGE_* In-Reply-To: <20250811143949.1117439-1-david@redhat.com> (David Hildenbrand's message of "Mon, 11 Aug 2025 16:39:46 +0200") References: <20250811143949.1117439-1-david@redhat.com> Date: Tue, 12 Aug 2025 09:29:40 +0800 Message-ID: <87bjolgwe3.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, David, David Hildenbrand writes: > This is against mm/mm-new. > > This series gets rid of MIGRATEPAGE_UNMAP, to then convert the remaining > MIGRATEPAGE_SUCCESS usage to simply use 0 instead. > > Not sure if it makes sense to split the second patch up, a treewide > cleanup felt more reasonable for this simple change in an area where > I don't expect a lot of churn. > > Briefly tested with virtio-mem in a VM, making sure that basic > page migration keeps working. > > Cc: Andrew Morton > Cc: Madhavan Srinivasan > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Jerrin Shaji George > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio P=C3=A9rez" > Cc: Alexander Viro > Cc: Christian Brauner > Cc: Jan Kara > Cc: Benjamin LaHaise > Cc: Chris Mason > Cc: Josef Bacik > Cc: David Sterba > Cc: Muchun Song > Cc: Oscar Salvador > Cc: Dave Kleikamp > Cc: Zi Yan > Cc: Matthew Brost > Cc: Joshua Hahn > Cc: Rakie Kim > Cc: Byungchul Park > Cc: Gregory Price > Cc: Ying Huang > Cc: Alistair Popple > Cc: Minchan Kim > Cc: Sergey Senozhatsky > > David Hildenbrand (2): > mm/migrate: remove MIGRATEPAGE_UNMAP > treewide: remove MIGRATEPAGE_SUCCESS LGTM. Feel free to add my Reviewed-by: Huang Ying for the whole series in the future versions. > arch/powerpc/platforms/pseries/cmm.c | 2 +- > drivers/misc/vmw_balloon.c | 4 +- > drivers/virtio/virtio_balloon.c | 2 +- > fs/aio.c | 2 +- > fs/btrfs/inode.c | 4 +- > fs/hugetlbfs/inode.c | 4 +- > fs/jfs/jfs_metapage.c | 8 +-- > include/linux/migrate.h | 11 +--- > mm/migrate.c | 80 ++++++++++++++-------------- > mm/migrate_device.c | 2 +- > mm/zsmalloc.c | 4 +- > 11 files changed, 56 insertions(+), 67 deletions(-) > > > base-commit: 53c448023185717d0ed56b5546dc2be405da92ff --- Best Regards, Huang, Ying