* Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
[not found] <20131216112408.GA4896@rashika>
@ 2013-12-16 14:23 ` Josh Triplett
2013-12-16 14:29 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Josh Triplett @ 2013-12-16 14:23 UTC (permalink / raw)
To: Rashika Kheria; +Cc: virtualization, linux-kernel, Michael S. Tsirkin
On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote:
> Mark the function virtballoon_migratepage() as static in
> virtio_balloon.c because it is not used outside this file.
>
> This eliminates the following warning in virtio_balloon.c:
> drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index c444654..8c5943d 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
> * This function preforms the balloon page migration task.
> * Called through balloon_mapping->a_ops->migratepage
> */
> -int virtballoon_migratepage(struct address_space *mapping,
> +static int virtballoon_migratepage(struct address_space *mapping,
> struct page *newpage, struct page *page, enum migrate_mode mode)
> {
> struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
> --
> 1.7.9.5
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
2013-12-16 14:23 ` [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Josh Triplett
@ 2013-12-16 14:29 ` Michael S. Tsirkin
2013-12-17 4:39 ` Rusty Russell
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2013-12-16 14:29 UTC (permalink / raw)
To: Josh Triplett; +Cc: Rashika Kheria, linux-kernel, virtualization
On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote:
> On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote:
> > Mark the function virtballoon_migratepage() as static in
> > virtio_balloon.c because it is not used outside this file.
> >
> > This eliminates the following warning in virtio_balloon.c:
> > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > drivers/virtio/virtio_balloon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> > index c444654..8c5943d 100644
> > --- a/drivers/virtio/virtio_balloon.c
> > +++ b/drivers/virtio/virtio_balloon.c
> > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
> > * This function preforms the balloon page migration task.
> > * Called through balloon_mapping->a_ops->migratepage
> > */
> > -int virtballoon_migratepage(struct address_space *mapping,
> > +static int virtballoon_migratepage(struct address_space *mapping,
> > struct page *newpage, struct page *page, enum migrate_mode mode)
> > {
> > struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
> > --
> > 1.7.9.5
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
2013-12-16 14:29 ` Michael S. Tsirkin
@ 2013-12-17 4:39 ` Rusty Russell
0 siblings, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2013-12-17 4:39 UTC (permalink / raw)
To: Michael S. Tsirkin, Josh Triplett
Cc: Rashika Kheria, linux-kernel, virtualization
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote:
>> On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote:
>> > Mark the function virtballoon_migratepage() as static in
>> > virtio_balloon.c because it is not used outside this file.
>> >
>> > This eliminates the following warning in virtio_balloon.c:
>> > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
>> >
>> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>>
>> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Thanks, applied.
Cheers,
Rusty.
>
>> > drivers/virtio/virtio_balloon.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
>> > index c444654..8c5943d 100644
>> > --- a/drivers/virtio/virtio_balloon.c
>> > +++ b/drivers/virtio/virtio_balloon.c
>> > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
>> > * This function preforms the balloon page migration task.
>> > * Called through balloon_mapping->a_ops->migratepage
>> > */
>> > -int virtballoon_migratepage(struct address_space *mapping,
>> > +static int virtballoon_migratepage(struct address_space *mapping,
>> > struct page *newpage, struct page *page, enum migrate_mode mode)
>> > {
>> > struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
>> > --
>> > 1.7.9.5
>> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c
@ 2013-12-16 11:24 Rashika Kheria
0 siblings, 0 replies; 4+ messages in thread
From: Rashika Kheria @ 2013-12-16 11:24 UTC (permalink / raw)
To: linux-kernel; +Cc: virtualization, josh, Michael S. Tsirkin
Mark the function virtballoon_migratepage() as static in
virtio_balloon.c because it is not used outside this file.
This eliminates the following warning in virtio_balloon.c:
drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index c444654..8c5943d 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops;
* This function preforms the balloon page migration task.
* Called through balloon_mapping->a_ops->migratepage
*/
-int virtballoon_migratepage(struct address_space *mapping,
+static int virtballoon_migratepage(struct address_space *mapping,
struct page *newpage, struct page *page, enum migrate_mode mode)
{
struct balloon_dev_info *vb_dev_info = balloon_page_device(page);
--
1.7.9.5
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-17 4:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20131216112408.GA4896@rashika>
2013-12-16 14:23 ` [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Josh Triplett
2013-12-16 14:29 ` Michael S. Tsirkin
2013-12-17 4:39 ` Rusty Russell
2013-12-16 11:24 Rashika Kheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).