Re: [PATCH 1/3] virtio_net: pass well-formed sgs to virtqueue_add_*()

Andy Lutomirski
2014-09-03T04:54:11Z

On Tue, Sep 2, 2014 at 9:29 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> This is the only driver which doesn't hand virtqueue_add_inbuf and
> virtqueue_add_outbuf a well-formed, well-terminated sg. Fix it,
> so we can make virtio_add_* simpler.

OK, I get it now: you're reinitializing the table every time, clearing
old end marks. There's room to microoptimize this, but it's probably
not worth it.

IOW, looks good to me.

--Andy