From: Rusty Russell <rusty@rustcorp.com.au>
To: Sebastian Ott <sebott@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-s390@vger.kernel.org, linux-pci@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH v3 10/16] s390: add pci_iomap_range
Date: Wed, 21 Jan 2015 11:13:14 +1030 [thread overview]
Message-ID: <87fvb5arq5.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LFD.2.11.1501161051380.1742@denkbrett>
Sebastian Ott <sebott@linux.vnet.ibm.com> writes:
> On Wed, 14 Jan 2015, Michael S. Tsirkin wrote:
>> }
>> -EXPORT_SYMBOL_GPL(pci_iomap);
>> +EXPORT_SYMBOL_GPL(pci_iomap_range);
>> +
>> +void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)
>> +{
>> + return pci_iomap_range(dev, bar, 0, maxlen);
>> +}
>> +EXPORT_SYMBOL(pci_iomap);
>
> As discussed earlier, could you please leave that as EXPORT_SYMBOL_GPL.
> If there's a reason to have these interfaces as EXPORT_SYMBOL, we could
> change all of them in an extra patch.
>
> With this change integrated you can add
> Acked-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
OK, I've gone back and rebased virtio-next to fix this (I don't really
want to think too hard about the legal consequences of having a version
which isn't EXPORT_SYMBOL_GPL).
Thanks,
Rusty.
next prev parent reply other threads:[~2015-01-21 0:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 17:27 [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 01/16] virtio_pci: drop virtio_config dependency Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 02/16] virtio/9p: verify device has config space Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 03/16] virtio/blk: " Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 04/16] virtio/console: " Michael S. Tsirkin
2015-01-20 10:40 ` Amit Shah
2015-01-20 11:09 ` Michael S. Tsirkin
2015-01-21 6:14 ` Amit Shah
2015-01-21 6:44 ` Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 05/16] virtio/net: " Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 06/16] virtio/scsi: " Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 07/16] virtio/balloon: " Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 08/16] mn10300: drop dead code Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 09/16] pci: add pci_iomap_range Michael S. Tsirkin
2015-01-14 17:27 ` [PATCH v3 10/16] s390: " Michael S. Tsirkin
2015-01-16 10:11 ` Sebastian Ott
[not found] ` <alpine.LFD.2.11.1501161051380.1742@denkbrett>
2015-01-21 0:43 ` Rusty Russell [this message]
2015-01-14 17:28 ` [PATCH v3 11/16] virtio_pci: move probe/remove code to common Michael S. Tsirkin
2015-01-14 17:28 ` [PATCH v3 12/16] virtio-pci: define layout for virtio 1.0 Michael S. Tsirkin
2015-01-14 17:28 ` [PATCH v3 13/16] virtio_pci: modern driver Michael S. Tsirkin
2015-01-14 17:28 ` [PATCH v3 14/16] virtio_pci: macros for PCI layout offsets Michael S. Tsirkin
2015-01-14 17:28 ` [PATCH v3 15/16] virtio_pci_modern: reduce number of mappings Michael S. Tsirkin
2015-01-14 17:28 ` [PATCH v3 16/16] virtio_pci_modern: support devices with no config Michael S. Tsirkin
2015-01-14 17:28 ` Michael S. Tsirkin
2015-01-14 17:28 ` Michael S. Tsirkin
2015-01-15 21:18 ` [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support Gerd Hoffmann
2015-01-15 21:32 ` Michael S. Tsirkin
2015-01-16 8:32 ` Gerd Hoffmann
2015-01-16 8:45 ` Michael S. Tsirkin
2015-01-16 13:27 ` Gerd Hoffmann
2015-01-19 10:54 ` Gerd Hoffmann
2015-01-20 16:38 ` Michael S. Tsirkin
2015-01-19 11:07 ` Gerd Hoffmann
2015-01-19 22:11 ` Michael S. Tsirkin
2015-01-20 16:32 ` Michael S. Tsirkin
2015-01-21 11:31 ` Gerd Hoffmann
[not found] ` <1421839868.11160.28.camel@nilsson.home.kraxel.org>
2015-01-21 11:36 ` Michael S. Tsirkin
2015-01-21 13:43 ` Gerd Hoffmann
2015-01-21 14:19 ` Michael S. Tsirkin
[not found] ` <1421256142-11512-9-git-send-email-mst@redhat.com>
2015-01-23 23:08 ` [PATCH v3 08/16] mn10300: drop dead code Bjorn Helgaas
[not found] ` <1421256142-11512-10-git-send-email-mst@redhat.com>
2015-01-23 23:08 ` [PATCH v3 09/16] pci: add pci_iomap_range Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvb5arq5.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=bhelgaas@google.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mst@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).