Linux virtualization list
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux-pm mailing list <linux-pm@vger.kernel.org>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_pci: pm: Use CONFIG_PM_SLEEP instead of CONFIG_PM
Date: Mon, 09 Sep 2013 10:03:18 +0930	[thread overview]
Message-ID: <87ob826dgx.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130906080744.GD29367@grmbl.mre>

Amit Shah <amit.shah@redhat.com> writes:

> On (Fri) 06 Sep 2013 [10:28:36], Aaron Lu wrote:
>> 
>> The virtio_pci_freeze/restore are defined under CONFIG_PM but is used
>> by SET_SYSTEM_SLEEP_PM_OPS macro, which is defined under
>> CONFIG_PM_SLEEP. So if CONFIG_PM_SLEEP is not cofigured but
>> CONFIG_PM_RUNTIME is, the following warning message appeared:
>> 
>> drivers/virtio/virtio_pci.c:770:12: warning: ‘virtio_pci_freeze’ defined but not used [-Wunused-function]
>>  static int virtio_pci_freeze(struct device *dev)
>>             ^
>> drivers/virtio/virtio_pci.c:790:12: warning: ‘virtio_pci_restore’ defined but not used [-Wunused-function]
>>  static int virtio_pci_restore(struct device *dev)
>>             ^
>> Fix it by changing CONFIG_PM to CONFIG_PM_SLEEP.
>> 
>> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> 		Amit

Applied.

Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2013-09-09  0:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52293DD4.6050403@intel.com>
2013-09-06  7:20 ` [PATCH] virtio_pci: pm: Use CONFIG_PM_SLEEP instead of CONFIG_PM Amit Shah
2013-09-06  7:41   ` Aaron Lu
     [not found]   ` <52298730.7020003@intel.com>
2013-09-06  8:07     ` Amit Shah
2013-09-06  8:07 ` Amit Shah
2013-09-09  0:33   ` Rusty Russell [this message]
2013-09-06  2:28 Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ob826dgx.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=aaron.lu@intel.com \
    --cc=amit.shah@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox