From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset Date: Mon, 04 Feb 2013 10:35:42 +1030 Message-ID: <87sj5dkko9.fsf@rustcorp.com.au> References: <1359190446-13677-1-git-send-email-ozaki.ryota@gmail.com> <1359367521.8090.10.camel@hornet> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359367521.8090.10.camel@hornet> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Pawel Moll , Ryota Ozaki Cc: Jiri Kosina , "virtualization@lists.linux-foundation.org" List-Id: virtualization@lists.linuxfoundation.org Pawel Moll writes: > On Sat, 2013-01-26 at 08:54 +0000, Ryota Ozaki wrote: >> The register offset of InterruptACK is 0x064, not 0x060. >> Fix it. >> >> Signed-off-by: Ryota Ozaki >> CC: Pawel Moll >> CC: Rusty Russell >> CC: Jiri Kosina >> --- >> drivers/virtio/virtio_mmio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c >> index 31f966f..833e6db 100644 >> --- a/drivers/virtio/virtio_mmio.c >> +++ b/drivers/virtio/virtio_mmio.c >> @@ -75,7 +75,7 @@ >> * >> * 0x050 W QueueNotify Queue notifier >> * 0x060 R InterruptStatus Interrupt status register >> - * 0x060 W InterruptACK Interrupt acknowledge register >> + * 0x064 W InterruptACK Interrupt acknowledge register >> * 0x070 RW Status Device status register >> * >> * 0x100+ RW Device-specific configuration space > > Acked-by: Pawel Moll > > Thanks! > > Pawel Applied. Thanks, Rusty.