* [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
@ 2013-01-26 8:54 Ryota Ozaki
2013-01-28 4:03 ` Wanlong Gao
2013-01-28 10:05 ` Pawel Moll
0 siblings, 2 replies; 4+ messages in thread
From: Ryota Ozaki @ 2013-01-26 8:54 UTC (permalink / raw)
To: virtualization; +Cc: Jiri Kosina, Pawel Moll
The register offset of InterruptACK is 0x064, not 0x060.
Fix it.
Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
CC: Pawel Moll <pawel.moll@arm.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Jiri Kosina <trivial@kernel.org>
---
drivers/virtio/virtio_mmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 31f966f..833e6db 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -75,7 +75,7 @@
*
* 0x050 W QueueNotify Queue notifier
* 0x060 R InterruptStatus Interrupt status register
- * 0x060 W InterruptACK Interrupt acknowledge register
+ * 0x064 W InterruptACK Interrupt acknowledge register
* 0x070 RW Status Device status register
*
* 0x100+ RW Device-specific configuration space
--
1.7.12
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
2013-01-26 8:54 [PATCH][trivial] virtio-mmio: fix wrong comment about register offset Ryota Ozaki
@ 2013-01-28 4:03 ` Wanlong Gao
2013-01-28 10:05 ` Pawel Moll
1 sibling, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2013-01-28 4:03 UTC (permalink / raw)
To: Ryota Ozaki; +Cc: Jiri Kosina, Pawel Moll, virtualization
On 01/26/2013 04:54 PM, Ryota Ozaki wrote:
> The register offset of InterruptACK is 0x064, not 0x060.
> Fix it.
>
> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
> CC: Pawel Moll <pawel.moll@arm.com>
> CC: Rusty Russell <rusty@rustcorp.com.au>
> CC: Jiri Kosina <trivial@kernel.org>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> drivers/virtio/virtio_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 31f966f..833e6db 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -75,7 +75,7 @@
> *
> * 0x050 W QueueNotify Queue notifier
> * 0x060 R InterruptStatus Interrupt status register
> - * 0x060 W InterruptACK Interrupt acknowledge register
> + * 0x064 W InterruptACK Interrupt acknowledge register
> * 0x070 RW Status Device status register
> *
> * 0x100+ RW Device-specific configuration space
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
2013-01-26 8:54 [PATCH][trivial] virtio-mmio: fix wrong comment about register offset Ryota Ozaki
2013-01-28 4:03 ` Wanlong Gao
@ 2013-01-28 10:05 ` Pawel Moll
2013-02-04 0:05 ` Rusty Russell
1 sibling, 1 reply; 4+ messages in thread
From: Pawel Moll @ 2013-01-28 10:05 UTC (permalink / raw)
To: Ryota Ozaki; +Cc: Jiri Kosina, virtualization@lists.linux-foundation.org
On Sat, 2013-01-26 at 08:54 +0000, Ryota Ozaki wrote:
> The register offset of InterruptACK is 0x064, not 0x060.
> Fix it.
>
> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
> CC: Pawel Moll <pawel.moll@arm.com>
> CC: Rusty Russell <rusty@rustcorp.com.au>
> CC: Jiri Kosina <trivial@kernel.org>
> ---
> drivers/virtio/virtio_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 31f966f..833e6db 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -75,7 +75,7 @@
> *
> * 0x050 W QueueNotify Queue notifier
> * 0x060 R InterruptStatus Interrupt status register
> - * 0x060 W InterruptACK Interrupt acknowledge register
> + * 0x064 W InterruptACK Interrupt acknowledge register
> * 0x070 RW Status Device status register
> *
> * 0x100+ RW Device-specific configuration space
Acked-by: Pawel Moll <pawel.moll@arm.com>
Thanks!
Pawel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
2013-01-28 10:05 ` Pawel Moll
@ 2013-02-04 0:05 ` Rusty Russell
0 siblings, 0 replies; 4+ messages in thread
From: Rusty Russell @ 2013-02-04 0:05 UTC (permalink / raw)
To: Pawel Moll, Ryota Ozaki
Cc: Jiri Kosina, virtualization@lists.linux-foundation.org
Pawel Moll <pawel.moll@arm.com> writes:
> On Sat, 2013-01-26 at 08:54 +0000, Ryota Ozaki wrote:
>> The register offset of InterruptACK is 0x064, not 0x060.
>> Fix it.
>>
>> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
>> CC: Pawel Moll <pawel.moll@arm.com>
>> CC: Rusty Russell <rusty@rustcorp.com.au>
>> CC: Jiri Kosina <trivial@kernel.org>
>> ---
>> drivers/virtio/virtio_mmio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
>> index 31f966f..833e6db 100644
>> --- a/drivers/virtio/virtio_mmio.c
>> +++ b/drivers/virtio/virtio_mmio.c
>> @@ -75,7 +75,7 @@
>> *
>> * 0x050 W QueueNotify Queue notifier
>> * 0x060 R InterruptStatus Interrupt status register
>> - * 0x060 W InterruptACK Interrupt acknowledge register
>> + * 0x064 W InterruptACK Interrupt acknowledge register
>> * 0x070 RW Status Device status register
>> *
>> * 0x100+ RW Device-specific configuration space
>
> Acked-by: Pawel Moll <pawel.moll@arm.com>
>
> Thanks!
>
> Pawel
Applied.
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-04 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-26 8:54 [PATCH][trivial] virtio-mmio: fix wrong comment about register offset Ryota Ozaki
2013-01-28 4:03 ` Wanlong Gao
2013-01-28 10:05 ` Pawel Moll
2013-02-04 0:05 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).