From: Juan Quintela <quintela@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Xiao W Wang" <xiao.w.wang@intel.com>,
"Harpreet Singh Anand" <hanand@xilinx.com>,
"Eli Cohen" <eli@mellanox.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
virtualization@lists.linux-foundation.org,
"Parav Pandit" <parav@mellanox.com>
Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq
Date: Tue, 02 Nov 2021 08:39:37 +0100 [thread overview]
Message-ID: <87v91bngzq.fsf@secure.mitica> (raw)
In-Reply-To: <20211102033023-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 2 Nov 2021 03:32:32 -0400")
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote:
>> Eugenio Pérez <eperezma@redhat.com> wrote:
>> > The -1 assumes that all devices with no cvq have an spare vq allocated
>> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the
>> > case, and the device may have a pair number of queues.
>> ^^^^
>> even
>>
>> I know, I know, I am Spanish myself O:-)
>
> Nobody expects the Spanish ;)
O:-)
>> int main(void)
>> {
>> int i = 7;
>> i &= -1ULL;
>
> Stefano's patch has ~1ULL , not -1ULL here.
>
Stupid eyes.
Thanks, Juan.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-02 7:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211029183525.1776416-1-eperezma@redhat.com>
[not found] ` <20211029183525.1776416-2-eperezma@redhat.com>
2021-10-31 18:59 ` [RFC PATCH v5 01/26] util: Make some iova_tree parameters const Juan Quintela
2021-11-02 4:25 ` [RFC PATCH v5 00/26] vDPA shadow virtqueue Jason Wang
[not found] ` <20211029183525.1776416-4-eperezma@redhat.com>
2021-11-02 4:57 ` [RFC PATCH v5 03/26] virtio: Add VIRTIO_F_QUEUE_STATE Jason Wang
[not found] ` <20211029183525.1776416-22-eperezma@redhat.com>
2021-11-02 5:25 ` [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq Jason Wang
[not found] ` <CAJaqyWfdZwW82cTXwfdyfcLZUyKyw7R2wcwF2SM0wwTcVmZ_yQ@mail.gmail.com>
2021-11-03 3:18 ` Jason Wang
[not found] ` <CAJaqyWcDrEyFX8xvGmePdA5-tN88JuPV+=GU26+d=u-kSO6gsQ@mail.gmail.com>
2021-11-04 2:34 ` Jason Wang
[not found] ` <20211029183525.1776416-13-eperezma@redhat.com>
2021-11-02 5:36 ` [RFC PATCH v5 12/26] vhost: Route guest->host notification through shadow virtqueue Jason Wang
[not found] ` <20211029183525.1776416-3-eperezma@redhat.com>
2021-11-02 7:25 ` [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq Juan Quintela
2021-11-02 7:32 ` Michael S. Tsirkin
2021-11-02 7:39 ` Juan Quintela [this message]
2021-11-02 7:40 ` Juan Quintela
[not found] ` <20211029183525.1776416-6-eperezma@redhat.com>
2021-11-02 7:36 ` [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp Juan Quintela
[not found] ` <20211029183525.1776416-12-eperezma@redhat.com>
2021-11-02 7:54 ` [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ Jason Wang
[not found] ` <CAJaqyWe56+wzXgdQp4nbGxhrSU4tPU+SkgTBUa=wSB5nSbtwuw@mail.gmail.com>
[not found] ` <CACGkMEvOxUMo1WA4tUfDhw+FOJVW87JJGPw=U3JvUSQTU_ogWQ@mail.gmail.com>
[not found] ` <CAJaqyWd4DQwRSL5StCft+3-uq12TW5x1o4DN_YW97D0JzOr2XQ@mail.gmail.com>
2021-11-04 2:31 ` Jason Wang
[not found] ` <20211029183525.1776416-23-eperezma@redhat.com>
2021-11-02 7:59 ` [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding Jason Wang
[not found] ` <20211029183525.1776416-24-eperezma@redhat.com>
2021-11-02 6:35 ` [RFC PATCH v5 23/26] util: Add iova_tree_alloc Jason Wang
[not found] ` <CAJaqyWeWCwFfznbPVjcOYQeFYeDmFJy9ViWx4bQnTzGp73O8Ww@mail.gmail.com>
2021-11-03 3:10 ` Jason Wang
2021-11-23 6:56 ` Peter Xu
2022-01-27 8:57 ` Peter Xu
[not found] ` <CAJaqyWd52cXWHnLsgo=kP2Z7=VG6YKtxFGhTe7OamfYcZxhz6w@mail.gmail.com>
2022-01-27 11:25 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91bngzq.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=hanand@xilinx.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).