From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stephen Hemminger <shemminger@vyatta.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] virtio_pci: fix macro exported in uapi
Date: Fri, 17 May 2013 09:39:07 +0930 [thread overview]
Message-ID: <87wqqy8o2k.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130516164446.GA32007@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> macro VIRTIO_PCI_CONFIG except in the unlikely event userspace
> actually has a structure with a field named msix_enabled.
> Get the msix_enabled by value instead, to make it useful
> for userspace.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Macro still isn't usable, because userspace can't know whether it's the
new or old.
We need to either remove it from UAPI, or rename it to
VIRTIO_PCI_CONFIG_OFF.
Cheers,
Rusty.
next prev parent reply other threads:[~2013-05-17 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 16:44 [PATCH] virtio_pci: fix macro exported in uapi Michael S. Tsirkin
2013-05-17 0:09 ` Rusty Russell [this message]
2013-05-17 8:57 ` David Howells
2013-05-20 0:08 ` Rusty Russell
2013-05-20 9:06 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqqy8o2k.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=shemminger@vyatta.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).