From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A01A3C4161 for ; Tue, 26 May 2026 06:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779778393; cv=none; b=HvghwcmcQ7ogkRkOloY4RxT/NIqwO9/QF9uXih6btTc9IMI76RqWhJEQkUwkfrKrbCWZn1+87JaQuDuOJ5ptzfUzIQM+Sa102co7lOdDG+en3yx4aV1cZ+EK8ELYWSLDGCsLxo9ddxDxJj6zY5qSQQLvQqrMTIKxvTPhxS/GTMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779778393; c=relaxed/simple; bh=lI94k3K5Kcc20pekEfGAOaAomJ1QgkYtP6G74MUe9gk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pVKToj7FU4QSwJwyxycc01G0JGIz4f4zM8PjfXkQY5/dwfzfUEoOuU4emvoIrb0JeVnb/omCvsY/7gc/jih5lpTGOEsu461IKOuWesmzL9QhR4ZL4vzECD/9bh09EklIlAmeyJ6RZKehAR51F/qqDuXng2rs+MuvHnw0vI+BfI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TZO0B4O7; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TZO0B4O7" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-45ea19f412aso2824958f8f.3 for ; Mon, 25 May 2026 23:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779778389; x=1780383189; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yXWASYjT/jE4WzpKhE8nVhHkzGwmPlTITkkcMF0D8BI=; b=TZO0B4O7iUMvbqIt7NQSABb62p2lsOX9XzzaWsfSHL5gwS9kH37v1h6DgSuiEDhON0 qzabjxxTUGXjvZvc8i+hhkWU5j42hYYPPtF+3O0/SvLiiC044Dy433iLkHKZaPiz68JJ +HYEnm6WM8n0UKqQWnmXD2KywUsGfK1lwPQ+SmEI0rpqOnvsSsh0z77cSykmFGxB23yn e9x+HBFkcpPRVljVKD470KWVRdgg96A+3rN4eUed8cYItovUpO0QoD/zf1QWXw2/qZkt 6VIVAg5tHZM3HgfE2WyJSLsrKqp5C4NHGXKSabKokb6Pv9SVTZ9EAJHXrQsqmJ8mrzbN 7HSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779778389; x=1780383189; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yXWASYjT/jE4WzpKhE8nVhHkzGwmPlTITkkcMF0D8BI=; b=X0cQaFogXSiVsO2LoqO/sO+ZF4PNb/Vg1msiLJPX019A/8DimpAxab+74xenEUNXVC G/5CupgirWNeShWLEkniSN8K9PY9JmGFzneJjuX5q9FpguDSiv2ykBOL+pRiF4UV1MSf ow/hOvP87SYUrmCnYccKqojTTI1RiyVRM3hqs/tpZLvosoafTBC8SPkTSFk/nM6SxsRD Nro5eIBLiVSxaT957cjNj/YFBXm5wKZq/pEfWGeT6s5VHzcESC5hbqKvKgsBRSWfKZRx sAyrA951QzZqjPL/pM9aiLKSBNe4Z7cjXQV1acLiGavntTpqFWAwrP4p8z8by1Aukm4B Vj7Q== X-Forwarded-Encrypted: i=1; AFNElJ89SsIKwS8XUD111dRbrYPkgXc2DqJihuJfjgtW08Xf/iOHr4QBnav5Szox1TcHqmHk9Idy3ig2spTkqCNfEQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yyhoqu+NRWRXsj1xgzQooPu4J8xZ/csGpvZ63OCBLdohaQCqTI0 trWfB68TJvmxuSmyp/NsM6hKWgNcGaTHd/Nu706Ltqps8Rzi0iXGmTFuhOaf7SZDidQ= X-Gm-Gg: Acq92OEsrm4SFkRGNc3bCRUkGGRCFPWAQ3RqRzhnBAHAG2HzJ8HcYVLlMc05jKuDLhi /A3PLYE21R9Iu6BIUt1YoRUsbQ9vSSEcfFrXZsVgqCJ1pEOg2fGQy/VJn1dkJKUfF0s80CzTwV1 +Ww4OWJAOMSSW1+Dv17H0040QxgUWP7WsK2Tq6Fz9V0Vi/Amw4yns2adSfYize9rEvTsC11+eaG MaF1OQh9dlVFcG15V0+ezsTe45I58TzQwnui6PxJZ4LZTpw8zrQsaLpiwRC7J1qQBMTGHkYDXuq TJGdFpb4Q/QK+S5KyHG1Ah46YnB0HVVDQ70MUoRiLm7RO1RJ0kZb5Z6KxvlznFX14VRn4ZrMUsb wnx9Qg2n7OMNvUL3isYIA0mmu9Mi7eCgELUT5WLxpbcfQ8lxLh7aN3fXvlyVefXhckRAe9QwGhf wfz37llm6vXVBkkJYktgGxfgvC/DAIivr6ddJ5bCoXugKedMOq+S/8moeU4WB9cDdbIW/vnSoZJ LxGIu5zHA14KsGV+L8Gajq2qQFDk9GuOc1dxJD+BLkYrncGqbaHZJ7F5mGViMa/JC8N+V8YTuer PQrP X-Received: by 2002:a05:6000:2003:b0:43b:4136:1e6f with SMTP id ffacd0b85a97d-45eb38e4b46mr29516257f8f.38.1779778389230; Mon, 25 May 2026 23:53:09 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9ba2esm33848641f8f.8.2026.05.25.23.53.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 23:53:08 -0700 (PDT) Message-ID: <88c5ca1d-eeda-4023-bc7a-397b92780db9@suse.com> Date: Tue, 26 May 2026 08:53:06 +0200 Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] Convert moduleparams to seq_buf To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260521133315.work.845-kees@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260521133315.work.845-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/21/26 3:33 PM, Kees Cook wrote: > Hi, > > I tried to trim the CC list here, but it's still pretty huge... > > We've had a long-standing issue with "write to a string pointer" callbacks > that don't bounds check the destination (and for which the bounds is > also not part of the callback prototype, even if it is "known" to be > PAGE_SIZE, which sysfs_emit() depends on). Both moduleparams and sysfs > use this pattern. As a first step, and to test the migration method, > migrate moduleparams first. > > There are 2 "mechanical" treewide patches that are handled by Coccinelle: > - treewide: Convert struct kernel_param_ops initializers to DEFINE_KERNEL_PARAM_OPS > - treewide: Convert custom kernel_param_ops .get callbacks to seq_buf via cocci > > The last treewide patch is manual, and may need to be broken up into > per-subsystem patches, though I'd prefer to avoid this, as it would > extend the migration from 1 relase to at least 2 releases. (1 to > release the migration infrastructure, then 1 release to collect all the > subsystem changes, and possibly 1 more release to remove the migration > infrastructure.) > > Thoughts, questions? This looks reasonable to me. I added a few minor comments on the patches but they already look solid. -- Thanks, Petr