Linux virtualization list
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Weilong Chen <chenweilong@huawei.com>,
	mst@redhat.com, virtualization@lists.linux-foundation.org,
	lizefan@huawei.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'
Date: Fri, 19 Jun 2020 15:54:19 +0800	[thread overview]
Message-ID: <953448d3-9e7c-3a96-b28b-edaf8b775e4d@redhat.com> (raw)
In-Reply-To: <20200619080333.194753-1-chenweilong@huawei.com>


On 2020/6/19 下午4:03, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."
> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
>   drivers/virtio/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
>   	depends on VIRTIO
>   	depends on MEMORY_HOTPLUG_SPARSE
>   	depends on MEMORY_HOTREMOVE
> -	select CONTIG_ALLOC
> +	depends on CONTIG_ALLOC
>   	help
>   	 This driver provides access to virtio-mem paravirtualized memory
>   	 devices, allowing to hotplug and hotunplug memory.


Acked-by: Jason Wang <jasowang@redhat.com>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2020-06-19  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19  8:03 [PATCH] virtio-mem: Fix build error due to improper use 'select' Weilong Chen
2020-06-19  7:54 ` Jason Wang [this message]
2020-06-19 11:39 ` Michael S. Tsirkin
2020-06-19 11:49 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=953448d3-9e7c-3a96-b28b-edaf8b775e4d@redhat.com \
    --to=jasowang@redhat.com \
    --cc=chenweilong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox