From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next 3/3] vhost: don't touch avail ring if in_order is negotiated Date: Mon, 26 Nov 2018 12:01:59 +0800 Message-ID: <99e6b6b0-3cc6-b100-1e60-aa837d293bc8@redhat.com> References: <20181123030016.4924-1-jasowang@redhat.com> <20181123030016.4924-4-jasowang@redhat.com> <20181123103750-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181123103750-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Ck9uIDIwMTgvMTEvMjMg5LiL5Y2IMTE6NDEsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiBP biBGcmksIE5vdiAyMywgMjAxOCBhdCAxMTowMDoxNkFNICswODAwLCBKYXNvbiBXYW5nIHdyb3Rl Ogo+PiBEZXZpY2UgdXNlIGRlc2NyaXB0b3JzIHRhYmxlIGluIG9yZGVyLCBzbyB0aGVyZSdzIG5v IG5lZWQgdG8gcmVhZAo+PiBpbmRleCBmcm9tIGF2YWlsYWJsZSByaW5nLiBUaGlzIGVsaW1pbmF0 ZSB0aGUgY2FjaGUgY29udGVudGlvbiBvbgo+PiBhdmFpbCByaW5nIGNvbXBsZXRlbHkuCj4gV2Vs bCB0aGlzIGlzbid0IHdoYXQgdGhlIGluIG9yZGVyIGZlYXR1cmUgc2F5cyBpbiB0aGUgc3BlYy4K Pgo+IEl0IGZvcmNlcyB0aGUgdXNlZCByaW5nIHRvIGJlIGluIHRoZSBzYW1lIG9yZGVyIGFzCj4g dGhlIGF2YWlsYWJsZSByaW5nLiBTbyBJIGRvbid0IHRoaW5rIHlvdSBjYW4gc2tpcAo+IGNoZWNr aW5nIHRoZSBhdmFpbGFibGUgcmluZy4KCgpNYXliZSBJIG1pc3Mgc29tZXRoaW5nLiBUaGUgc3Bl YyAKKGh0dHBzOi8vZ2l0aHViLmNvbS9vYXNpcy10Y3MvdmlydGlvLXNwZWMgbWFzdGVyKSBzYWlk OiAiSWYgClZJUlRJT19GX0lOX09SREVSIGhhcyBiZWVuIG5lZ290aWF0ZWQsIGRyaXZlciB1c2Vz IGRlc2NyaXB0b3JzIGluIHJpbmcgCm9yZGVyOiBzdGFydGluZyBmcm9tIG9mZnNldCAwIGluIHRo ZSB0YWJsZSwgYW5kIHdyYXBwaW5nIGFyb3VuZCBhdCB0aGUgCmVuZCBvZiB0aGUgdGFibGUuIgoK RXZlbiBpZiBJIHdhcyB3cm9uZywgbWF5YmUgaXQncyB0aW1lIHRvIGZvcmNlIHRoaXMgY29uc2lk ZXIgdGhlIG9idmlvdXMgCmltcHJvdmVtZW50IGl0IGJyaW5ncz8gQW5kIG1heWJlIHdoYXQgeW91 IHNhaWQgaXMgdGhlIHJlYXNvbiB0aGF0IHdlIApvbmx5IGFsbG93IHRoZSBmb2xsb3dpbmcgb3B0 aW1pemF0aW9uIG9ubHkgZm9yIHBhY2tlZCByaW5nPwoKIm5vdGlmeSB0aGUgdXNlIG9mIGEgYmF0 Y2ggb2YgYnVmZmVycyB0byB0aGUgZHJpdmVyIGJ5IG9ubHkgd3JpdGluZyBvdXQgCmEgc2luZ2xl IHVzZWQgZGVzY3JpcHRvciB3aXRoIHRoZSBCdWZmZXIgSUQgY29ycmVzcG9uZGluZyB0byB0aGUg bGFzdCAKZGVzY3JpcHRvciBpbiB0aGUgYmF0Y2guICIKClRoaXMgc2VlbXMgYW5vdGhlciBnb29k IG9wdGltaXphdGlvbiBmb3IgcGFja2VkIHJpbmcgYXMgd2VsbC4KCgo+IEFuZCBpbiBmYWN0IGRl cGVuZGluZyBvbgo+IHJpbmcgc2l6ZSBhbmQgd29ya2xvYWQsIHVzaW5nIGFsbCBvZiBkZXNjcmlw dG9yIGJ1ZmZlciBtaWdodAo+IGNhdXNlIGEgc2xvd2Rvd24uCgoKVGhpcyBpcyBub3QgdGhlIHNp biBvZiBpbiBvcmRlciBidXQgdGhlIHNpemUgb2YgdGhlIHF1ZXVlIEkgYmVsaWV2ZT8KCgo+IFJh dGhlciB5b3Ugc2hvdWxkIGJlIGFibGUgdG8gZ2V0Cj4gYWJvdXQgdGhlIHNhbWUgc3BlZWR1cCwg YnV0IGZyb20gc2tpcHBpbmcgY2hlY2tpbmcKPiB0aGUgdXNlZCByaW5nIGluIHZpcnRpby4KCgpZ ZXMsIEkndmUgbWFkZSBzdWNoIGNoYW5nZXMgaW4gdmlydGlvLW5ldCBwbWQuIEJ1dCBzaW5jZSB3 ZSdyZSB0ZXN0aW5nIAppdCB3aXRoIHZob3N0LWtlcm5lbCwgdGhlIG1haW4gY29udGVudGlvbiB3 YXMgb24gYXZhaWxhYmxlLiBTbyB0aGUgCmltcHJvdmVtZW50IHdhcyBub3Qgb2J2aW91cy4KClRo YW5rcwoKCj4KPgo+PiBWaXJpdG8tdXNlciArIHZob3N0X2tlcm5lbCArIFhEUF9EUk9QIGdpdmVz IGFib3V0IH4xMCUgaW1wcm92ZW1lbnQgb24KPj4gVFggZnJvbSA0LjhNcHBzIHRvIDUuM01wcHMg b24gSW50ZWwoUikgQ29yZShUTSkgaTctNTYwMFUgQ1BVIEAKPj4gMi42MEdIei4KPj4KPj4gU2ln bmVkLW9mZi1ieTogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KPj4gLS0tCj4+ICAg ZHJpdmVycy92aG9zdC92aG9zdC5jIHwgMTkgKysrKysrKysrKysrLS0tLS0tLQo+PiAgIDEgZmls ZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy92aG9zdC92aG9zdC5jIGIvZHJpdmVycy92aG9zdC92aG9zdC5jCj4+IGlu ZGV4IDNhNWY4MWE2NmQzNC4uYzhiZTE1MWJjODk3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3Zo b3N0L3Zob3N0LmMKPj4gKysrIGIvZHJpdmVycy92aG9zdC92aG9zdC5jCj4+IEBAIC0yMDAyLDYg KzIwMDIsNyBAQCBpbnQgdmhvc3RfZ2V0X3ZxX2Rlc2Moc3RydWN0IHZob3N0X3ZpcnRxdWV1ZSAq dnEsCj4+ICAgCV9fdmlydGlvMTYgYXZhaWxfaWR4Owo+PiAgIAlfX3ZpcnRpbzE2IHJpbmdfaGVh ZDsKPj4gICAJaW50IHJldCwgYWNjZXNzOwo+PiArCWJvb2wgaW5fb3JkZXIgPSB2aG9zdF9oYXNf ZmVhdHVyZSh2cSwgVklSVElPX0ZfSU5fT1JERVIpOwo+PiAgIAo+PiAgIAkvKiBDaGVjayBpdCBp c24ndCBkb2luZyB2ZXJ5IHN0cmFuZ2UgdGhpbmdzIHdpdGggZGVzY3JpcHRvciBudW1iZXJzLiAq Lwo+PiAgIAlsYXN0X2F2YWlsX2lkeCA9IHZxLT5sYXN0X2F2YWlsX2lkeDsKPj4gQEAgLTIwMzQs MTUgKzIwMzUsMTkgQEAgaW50IHZob3N0X2dldF92cV9kZXNjKHN0cnVjdCB2aG9zdF92aXJ0cXVl dWUgKnZxLAo+PiAgIAo+PiAgIAkvKiBHcmFiIHRoZSBuZXh0IGRlc2NyaXB0b3IgbnVtYmVyIHRo ZXkncmUgYWR2ZXJ0aXNpbmcsIGFuZCBpbmNyZW1lbnQKPj4gICAJICogdGhlIGluZGV4IHdlJ3Zl IHNlZW4uICovCj4+IC0JaWYgKHVubGlrZWx5KHZob3N0X2dldF9hdmFpbCh2cSwgcmluZ19oZWFk LAo+PiAtCQkgICAgICZ2cS0+YXZhaWwtPnJpbmdbbGFzdF9hdmFpbF9pZHggJiAodnEtPm51bSAt IDEpXSkpKSB7Cj4+IC0JCXZxX2Vycih2cSwgIkZhaWxlZCB0byByZWFkIGhlYWQ6IGlkeCAlZCBh ZGRyZXNzICVwXG4iLAo+PiAtCQkgICAgICAgbGFzdF9hdmFpbF9pZHgsCj4+IC0JCSAgICAgICAm dnEtPmF2YWlsLT5yaW5nW2xhc3RfYXZhaWxfaWR4ICUgdnEtPm51bV0pOwo+PiAtCQlyZXR1cm4g LUVGQVVMVDsKPj4gKwlpZiAoIWluX29yZGVyKSB7Cj4+ICsJCWlmICh1bmxpa2VseSh2aG9zdF9n ZXRfYXZhaWwodnEsIHJpbmdfaGVhZCwKPj4gKwkJICAgICZ2cS0+YXZhaWwtPnJpbmdbbGFzdF9h dmFpbF9pZHggJiAodnEtPm51bSAtIDEpXSkpKSB7Cj4+ICsJCQl2cV9lcnIodnEsICJGYWlsZWQg dG8gcmVhZCBoZWFkOiBpZHggJWQgYWRkcmVzcyAlcFxuIiwKPj4gKwkJCQlsYXN0X2F2YWlsX2lk eCwKPj4gKwkJCQkmdnEtPmF2YWlsLT5yaW5nW2xhc3RfYXZhaWxfaWR4ICUgdnEtPm51bV0pOwo+ PiArCQkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICsJCX0KPj4gKwkJaGVhZCA9IHZob3N0MTZfdG9fY3B1 KHZxLCByaW5nX2hlYWQpOwo+PiArCX0gZWxzZSB7Cj4+ICsJCWhlYWQgPSBsYXN0X2F2YWlsX2lk eCAmICh2cS0+bnVtIC0gMSk7Cj4+ICAgCX0KPj4gICAKPj4gLQloZWFkID0gdmhvc3QxNl90b19j cHUodnEsIHJpbmdfaGVhZCk7Cj4+ICAgCj4+ICAgCS8qIElmIHRoZWlyIG51bWJlciBpcyBzaWxs eSwgdGhhdCdzIGFuIGVycm9yLiAqLwo+PiAgIAlpZiAodW5saWtlbHkoaGVhZCA+PSB2cS0+bnVt KSkgewo+PiAtLSAKPj4gMi4xNy4xCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==