From: Paolo Bonzini <pbonzini@redhat.com>
To: Yury Kamenev <damtev@yandex-team.ru>,
mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
axboe@kernel.dk, hch@lst.de, cand@gmx.com,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block
Date: Thu, 15 Jul 2021 13:22:16 +0200 [thread overview]
Message-ID: <9bd3c75a-63b3-427c-c54c-cd12587ba58b@redhat.com> (raw)
In-Reply-To: <20210715094707.19997-2-damtev@yandex-team.ru>
On 15/07/21 11:47, Yury Kamenev wrote:
> +#ifdef CONFIG_VIRTIO_BLK_NO_PART_SCAN
> + if (unlikely(partitions_scanning_disable))
> + /* disable partitions scanning if it was stated in virtio features*/
> + if (virtio_has_feature(vdev, VIRTIO_BLK_F_NO_PART_SCAN))
> + vblk->disk->flags |= GENHD_FL_NO_PART_SCAN;
> +#endif
> +
Has this been added to the spec? It doesn't seem like a good idea, as
pointed out by Stefan[1], Christoph[2] and myself[3].
Paolo
[1]
https://lore.kernel.org/linux-block/20210524145654.GA2632@lst.de/T/#m2697cb41578490aad49ed1d8fa6604bf0924b54d
[2]
https://lore.kernel.org/linux-block/20210524145654.GA2632@lst.de/T/#mc59329fd824102f94ac2f6b29fe94a652849aca0
[3]
https://lore.kernel.org/linux-block/20210524145654.GA2632@lst.de/T/#mee6787c4fd87790b64feccc9e77fd5f618c2c336
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-07-15 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210715094707.19997-1-damtev@yandex-team.ru>
[not found] ` <20210715094707.19997-2-damtev@yandex-team.ru>
2021-07-15 11:22 ` Paolo Bonzini [this message]
2021-07-16 1:09 ` [PATCH 1/1] virtio: disable partitions scanning for no partitions block kernel test robot
2021-07-16 2:57 ` Jason Wang
[not found] <20210520133908.98891-1-damtev@yandex-team.ru>
[not found] ` <20210520133908.98891-2-damtev@yandex-team.ru>
2021-05-24 14:29 ` Stefan Hajnoczi
2021-05-24 14:56 ` Christoph Hellwig
2021-05-24 16:25 ` Ulf Hansson
[not found] ` <90021621883891@mail.yandex-team.ru>
2021-05-24 19:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd3c75a-63b3-427c-c54c-cd12587ba58b@redhat.com \
--to=pbonzini@redhat.com \
--cc=axboe@kernel.dk \
--cc=cand@gmx.com \
--cc=damtev@yandex-team.ru \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).