From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>,
linux-kernel@vger.kernel.org, levinsasha928@gmail.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH v4 04/12] virtio: console: Add freeze and restore handlers to support S4
Date: Wed, 7 Dec 2011 01:18:42 +0530 [thread overview]
Message-ID: <9f09629340556ddac37135bc3aab233f1154f86a.1323199985.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1323199985.git.amit.shah@redhat.com>
In-Reply-To: <cover.1323199985.git.amit.shah@redhat.com>
Remove all vqs and associated buffers in the freeze callback which
prepares us to go into hibernation state. On restore, re-create all the
vqs and populate the input vqs with buffers to get to the pre-hibernate
state.
Note: Any outstanding unconsumed buffers are discarded; which means
there's a possibility of data loss in case the host or the guest didn't
consume any data already present in the vqs. This can be addressed in a
later patch series, perhaps in virtio common code.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 58 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 58 insertions(+), 0 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index e14f5aa..fd2fd6f 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1844,6 +1844,60 @@ static unsigned int features[] = {
VIRTIO_CONSOLE_F_MULTIPORT,
};
+#ifdef CONFIG_PM
+static int virtcons_freeze(struct virtio_device *vdev)
+{
+ struct ports_device *portdev;
+ struct port *port;
+
+ portdev = vdev->priv;
+
+ vdev->config->reset(vdev);
+
+ cancel_work_sync(&portdev->control_work);
+ remove_controlq_data(portdev);
+
+ list_for_each_entry(port, &portdev->ports, list) {
+ /*
+ * We'll ask the host later if the new invocation has
+ * the port opened or closed.
+ */
+ port->host_connected = false;
+ remove_port_data(port);
+ }
+ remove_vqs(portdev);
+
+ return 0;
+}
+
+static int virtcons_restore(struct virtio_device *vdev)
+{
+ struct ports_device *portdev;
+ struct port *port;
+ int ret;
+
+ portdev = vdev->priv;
+
+ ret = init_vqs(portdev);
+ if (ret)
+ return ret;
+
+ if (use_multiport(portdev))
+ fill_queue(portdev->c_ivq, &portdev->cvq_lock);
+
+ list_for_each_entry(port, &portdev->ports, list) {
+ port->in_vq = portdev->in_vqs[port->id];
+ port->out_vq = portdev->out_vqs[port->id];
+
+ fill_queue(port->in_vq, &port->inbuf_lock);
+
+ /* Get port open/close status on the host */
+ send_control_msg(port, VIRTIO_CONSOLE_PORT_READY, 1);
+ }
+ return 0;
+}
+#endif
+
static struct virtio_driver virtio_console = {
.feature_table = features,
.feature_table_size = ARRAY_SIZE(features),
@@ -1853,6 +1907,10 @@ static struct virtio_driver virtio_console = {
.probe = virtcons_probe,
.remove = virtcons_remove,
.config_changed = config_intr,
+#ifdef CONFIG_PM
+ .freeze = virtcons_freeze,
+ .restore = virtcons_restore,
+#endif
};
static int __init init(void)
--
1.7.7.3
next prev parent reply other threads:[~2011-12-06 19:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 19:48 [PATCH v4 00/12] virtio: s4 support Amit Shah
2011-12-06 19:48 ` [PATCH v4 01/12] virtio: pci: switch to new PM API Amit Shah
2011-12-06 22:12 ` Rafael J. Wysocki
2011-12-07 3:57 ` Amit Shah
2011-12-07 9:48 ` Rafael J. Wysocki
2011-12-07 9:52 ` Amit Shah
2011-12-07 10:16 ` Rafael J. Wysocki
2011-12-06 19:48 ` [PATCH v4 02/12] virtio: pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-12-06 19:48 ` [PATCH v4 03/12] virtio: console: Move out vq and vq buf removal into separate functions Amit Shah
2011-12-06 19:48 ` Amit Shah [this message]
2011-12-07 10:43 ` [PATCH v4 04/12] virtio: console: Add freeze and restore handlers to support S4 Michael S. Tsirkin
2011-12-07 10:59 ` Amit Shah
2011-12-07 15:54 ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 05/12] virtio: blk: Move out vq initialization to separate function Amit Shah
2011-12-06 19:48 ` [PATCH v4 06/12] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-12-07 10:37 ` Michael S. Tsirkin
2011-12-07 10:56 ` Amit Shah
2011-12-07 15:58 ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 07/12] virtio: net: Move out vq initialization into separate function Amit Shah
2011-12-06 19:48 ` [PATCH v4 08/12] virtio: net: Move out vq and vq buf removal " Amit Shah
2011-12-06 19:48 ` [PATCH v4 09/12] virtio: net: Add freeze, restore handlers to support S4 Amit Shah
2011-12-07 10:28 ` Michael S. Tsirkin
2011-12-07 10:35 ` Amit Shah
2011-12-07 11:46 ` Michael S. Tsirkin
2011-12-06 19:48 ` [PATCH v4 10/12] virtio: balloon: ensure thread exists before stopping it Amit Shah
2011-12-06 19:48 ` [PATCH v4 11/12] virtio: balloon: Move out vq initialization into separate function Amit Shah
2011-12-06 19:48 ` [PATCH v4 12/12] virtio: balloon: Add freeze, restore handlers to support S4 Amit Shah
2011-12-07 4:50 ` Amit Shah
2011-12-07 10:34 ` (resend) " Michael S. Tsirkin
2011-12-07 10:39 ` Amit Shah
2011-12-07 7:24 ` [PATCH v4 00/12] virtio: s4 support Rusty Russell
[not found] ` <87wra8j13m.fsf@rustcorp.com.au>
2011-12-07 7:44 ` Amit Shah
2011-12-07 10:52 ` Rusty Russell
2011-12-08 11:56 ` Amit Shah
2011-12-07 10:44 ` Gleb Natapov
2011-12-07 13:43 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f09629340556ddac37135bc3aab233f1154f86a.1323199985.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).