virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jason@lakedaemon.net, keescook@chromium.org,
	Virtualization List <virtualization@lists.linux-foundation.org>,
	Amit Shah <amit.shah@redhat.com>,
	herbert@gondor.apana.org.au
Subject: [PATCH v2 2/4] virtio: rng: re-arrange struct elements for better packing
Date: Mon, 21 Jul 2014 17:15:50 +0530	[thread overview]
Message-ID: <9ffa7e1b77b9d6fd5b5e736bc02a2e2db62aede1.1405942162.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1405942162.git.amit.shah@redhat.com>
In-Reply-To: <cover.1405942162.git.amit.shah@redhat.com>

Re-arrange the elements of the virtrng_info struct to pack it better.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 drivers/char/hw_random/virtio-rng.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index d8ffebd..a156284 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -30,11 +30,11 @@ static DEFINE_IDA(rng_index_ida);
 struct virtrng_info {
 	struct hwrng hwrng;
 	struct virtqueue *vq;
-	unsigned int data_avail;
 	struct completion have_data;
-	bool busy;
 	char name[25];
+	unsigned int data_avail;
 	int index;
+	bool busy;
 };
 
 static bool probe_done;
-- 
1.9.3

  parent reply	other threads:[~2014-07-21 11:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 11:45 [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Amit Shah
2014-07-21 11:45 ` [PATCH v2 1/4] virtio: rng: remove unused struct element Amit Shah
2014-07-21 11:45 ` Amit Shah [this message]
2014-07-21 11:45 ` [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready Amit Shah
2014-07-21 12:11   ` Jason Cooper
2014-07-21 12:21     ` Amit Shah
2014-07-21 12:41     ` Herbert Xu
2014-07-22 11:43       ` Jason Cooper
2014-07-22 17:08   ` Amit Shah
2014-07-23  5:51     ` Rusty Russell
2014-07-21 11:45 ` [PATCH v2 4/4] Revert "hwrng: virtio - ensure reads happen after successful probe" Amit Shah
2014-07-22 11:46 ` [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Jason Cooper
2014-07-22 15:08   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ffa7e1b77b9d6fd5b5e736bc02a2e2db62aede1.1405942162.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jason@lakedaemon.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).