virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: virtualization <virtualization@lists.linux-foundation.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 3/6] vduse: Add sysfs interface for irq affinity setup
Date: Wed, 16 Nov 2022 15:11:30 +0800	[thread overview]
Message-ID: <CACGkMEstonrKHHkr2Bi3Yd=driTMu_qBC5D9Xvxz4pWqs23e-w@mail.gmail.com> (raw)
In-Reply-To: <CACycT3uwqNb=+9P=Ta7pw5qUCRfJXveMUX==CYPrtE=+OQBCrg@mail.gmail.com>

On Tue, Nov 15, 2022 at 10:49 AM Yongji Xie <xieyongji@bytedance.com> wrote:
>
> On Mon, Nov 14, 2022 at 4:55 PM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Mon, Nov 14, 2022 at 4:20 PM Yongji Xie <xieyongji@bytedance.com> wrote:
> > >
> > > On Mon, Nov 14, 2022 at 3:58 PM Jason Wang <jasowang@redhat.com> wrote:
> > > >
> > > > On Mon, Nov 14, 2022 at 3:16 PM Xie Yongji <xieyongji@bytedance.com> wrote:
> > > > >
> > > > > Add sysfs interface for each vduse virtqueue to setup
> > > > > irq affinity. This would be useful for performance
> > > > > tuning, e.g., mitigate the virtqueue lock contention
> > > > > in virtio block driver.
> > > >
> > > > Do we have any perforamnce numbers for this?
> > > >
> > >
> > > Almost 50% improvement (600k iops -> 900k iops) in the high iops
> > > workloads. I have mentioned it in the cover-letter.
> >
> > For some reason, I miss that.
> >
> > I also wonder if we can do this automatically, then there's no need to
> > play with sysfs which is kind of a burden for the management layer.
> >
>
> This is hard to do since vduse doesn't know which cpu should be bound
> for a certain virtqueue.

Probably via the kick_vq()? It probably won't work when notification
is disabled. But we need to think a little bit more about this.
Requiring management software to do ad-hoc running just for VDUSE
seems not easy.

Thanks

>
> Thanks,
> Yongji
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-11-16  7:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221114070233.248-1-xieyongji@bytedance.com>
     [not found] ` <20221114070233.248-4-xieyongji@bytedance.com>
2022-11-14  7:58   ` [PATCH 3/6] vduse: Add sysfs interface for irq affinity setup Jason Wang
     [not found]     ` <CACycT3s8CbO1YD3AAzN-iXEkf6MKM7ihK+=NFik+33HDjanBJQ@mail.gmail.com>
2022-11-14  8:55       ` Jason Wang
     [not found]         ` <CACycT3uwqNb=+9P=Ta7pw5qUCRfJXveMUX==CYPrtE=+OQBCrg@mail.gmail.com>
2022-11-16  7:11           ` Jason Wang [this message]
     [not found] ` <20221114070233.248-2-xieyongji@bytedance.com>
2022-11-17  5:17   ` [PATCH 1/6] vduse: Refactor allocation for vduse virtqueues Jason Wang
     [not found] ` <20221114070233.248-7-xieyongji@bytedance.com>
2022-11-17  5:26   ` [PATCH 6/6] vduse: Support specifying bounce buffer size via sysfs Jason Wang
     [not found]     ` <CACycT3vSbwhsrM6R8Sd23e=AfkYh18rx-4FscnWEVGiWiu4rQQ@mail.gmail.com>
2022-11-17  6:12       ` Jason Wang
     [not found] <CACycT3siOCZv+u+-Xcto9BEdY1c8t_ivw-DF73bmuLqBRxF7=A@mail.gmail.com>
2022-11-17  3:36 ` [PATCH 3/6] vduse: Add sysfs interface for irq affinity setup Jason Wang
     [not found]   ` <CACycT3vPyEuQcJEEPJE2Dv-49f=w8xLoOXsoLb5Fjtx9uqQoyQ@mail.gmail.com>
2022-11-17  6:07     ` Jason Wang
     [not found]       ` <CACycT3uH-OPZ9BUR1OnXmY8Lx0vhYTq=Gb3S9i6thGApa5GHFQ@mail.gmail.com>
2022-11-18  7:23         ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACGkMEstonrKHHkr2Bi3Yd=driTMu_qBC5D9Xvxz4pWqs23e-w@mail.gmail.com' \
    --to=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).